Skip to content

Uhuru RAVEN: Adding platform HAL #10091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 919 commits into from
Closed

Conversation

junichikatsu
Copy link
Contributor

Description

Uhuru RAVEN: Adding platform HAL

This pull request is a reissue of the next pull request. I made a branch and made a pull request.
#9787

Test results:
GCC
ARM
IAR

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Mel Weed and others added 30 commits February 8, 2019 16:45
Remove reference to yotta, and fix spelling for correct branding.
The relationnal operators were targeting the base class which defines an implicit constructor to an integral value. This is wrong as it allows SafeEnum instances to be compared against integers.

The fix is simple: define relationnal operators for the derived class. The derived class is known as it is passed as a template parameter of the base class.

For extra safety the SafeEnum constructor is now explicit and protected.
PSoC 6 hex files contain 4-byte chip ID at virtual offset 0x90500002
added by PSoC Creator or cymcuelftool from .cymeta ELF section.
merge_images compares chip ID in CM0+ and CM4 hex files and raises
an exception in case of mismatch. Chip ID is different for each MPN
(for example, 0xE2072100 for CY8C6347BZI-BLD53 and 0xE2062100 for
CY8C6247BZI-D54). CM0+ prebuilt images target CY8C6347BZI-BLD53
but should be compatible with other PSoC6 MPNs.
Remove the check to enable merging CM0+ images with CM4 applications
built for different MPNs, with empty or absent cymetadata.
Replace hard-coded numeric offsets of PSoC 6 hex file sections
with sensible constants.
Do not attempt to update the checksum and metadata contents
if the sections are not found in the original HEX file.
Rename the existing PSoC-specific m0_core_img key in targets.json
as a more generic hex_filename key. Update makefile exporter to select
the subset of resources.hex_files matching the hex_filename value.
Without this fix, multiple prebuilt CM0+ hex files are found in the
target resources and erroneously passed to the srec_cat tool.

The fix is generic so other targets that need post-build hex merging
can use this key to pass the correct image to srecord tool.

The fix also removes sub_target key: instead, rely hex_filename json
key to detect if the hex image merging needs to be done.
The sub_target is not used in mbed-os codebase for anything else.

It is possible to override the hex file name in mbed_app.json:
{
  "target_overrides": {
    "*": {
      "target.hex_filename": "my_custom_m0_image.hex"
    }
}
Remove all references to yotta.md
Make change suggested in comments.
Remove requested outdated content, and update TOC to reflect changes.
DAPLink implementation on Cypress kits cannot handle hex files
with 64 bytes per row: refer to https://github.com/ARMmbed/DAPLink,
source/daplink/drag-n-drop/intelhex.c, hex_line_t struct, data field.
Fix for issue 9402

Signed-off-by: Mahesh Mahadevan <[email protected]>
Test buffer size can now be specified for each target
TLSSocket tests based on existing TCPSocket greentea tests and TLSSocket icetea tests.
The whole README.md had to be updated to match the internal Confluence documentation, which can now be locked. In the process I also updated any spotted mistakes in tests documentation, removed the obsolete TCPServer tests documentation and added a test which was missing from UDPSocket's main.
This change allows the latest releases of mbed-ls, mbed-host-tests, and
mbed-greentea. This brings new target support, features, and bug fixes.
FlashIAPBlockDevice LittleFS ‘fopen’ falls on nightly tests
LittleFS test on FlashIAP is not relevant and thus removed
@ciarmcom ciarmcom requested review from Ronny-Liu, screamerbg, soramame21 and a team March 14, 2019 00:01
@ciarmcom
Copy link
Member

@junichikatsu, thank you for your changes.
@soramame21 @screamerbg @maclobdell @Ronny-Liu @MarceloSalazar @ARMmbed/mbed-os-core @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-test @ARMmbed/mbed-os-tls @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-mesh please review.

@cmonr cmonr removed request for a team March 14, 2019 00:14
@cmonr
Copy link
Contributor

cmonr commented Mar 14, 2019

@junichikatsu This PR confuses me.

How did the commit history manage to pull inthis commit:
Merge pull request #9719 from ARMmbed/release-candidate

which wasn't even targeting master?

Would you mind sharing the commands or exact steps you used to make this branch?

For reference, when creating a PR, take a look at this title bar:
image

If the number of commits or files edited don't match what you are expecting, something isn't correct.

@junichikatsu
Copy link
Contributor Author

@cmonr
Sorry for the confusion.
This pull request is canceled because the repository configuration is reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.