Skip to content

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Mar 25, 2019

Description

This PR adds button name definitions BUTTON1/BUTTON2 for Nuvoton targets:

  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487/NUMAKER_IOT_M487
  • NUMAKER_PFM_M2351

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team and Ronny-Liu March 25, 2019 06:00
@cmonr
Copy link
Contributor

cmonr commented Mar 25, 2019

Waiting on #10221 for astyle fix.

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

Hmm... The astyle fix is missing this fix: #10222

@NirSonnenschein
Copy link
Contributor

please re-base when you have time, it should resolve the astyle issue

@ccli8 ccli8 force-pushed the nuvoton_add-button-name branch from 45d04fb to be96ade Compare March 26, 2019 09:06
@ccli8
Copy link
Contributor Author

ccli8 commented Mar 26, 2019

@NirSonnenschein Rebase done

@cmonr
Copy link
Contributor

cmonr commented Mar 26, 2019

CI started

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019
…name

Nuvoton: Add button names BUTTON1/BUTTON2
@mbed-ci
Copy link

mbed-ci commented Mar 26, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit be38d95 into ARMmbed:master Mar 27, 2019
@ccli8 ccli8 deleted the nuvoton_add-button-name branch March 27, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants