-
Notifications
You must be signed in to change notification settings - Fork 3k
Explaining how to opt in modules #10991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explaining how to opt in modules #10991
Conversation
Add a section in the CC Readme file explaining how to enable the optional module.
@RonEld, thank you for your changes. |
There are three additional modules that have alternative implementation support, which are not enabled by default. | ||
The reason is to allow backwards compatability, as these modules don't have full functionality, and return `MBEDTLS_ERR_PLATFORM_FEATURE_UNSUPPORTED` for some features. | ||
The modules are: | ||
* `AES` which only supports 128 bit key size, in opposed to previous suipport for all key sizes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
support
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@0xc0170 Does this require review from @ARMmbed/mbed-docs ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnotherButler will do better :) Otherwise looks good to me
|
||
## Enabling optional alternative drivers | ||
|
||
There are three additional modules that have alternative implementation support, which are not enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are three additional modules that have alternative implementation support, which are not enabled by default. | |
There are three additional modules with alternative implementation support, disabled by default. |
@AnotherButler , please add your review comments. |
Edit file, mostly for active voice, formatting and parallel construction.
Should this be added to our public, published Mbed OS documentation, or is it not going onto master? |
@AnotherButler This is secifically for Cryptocell, so I think this readme file is enough. |
@Patater Will we want to add this to the published docs when these features are no longer optional? |
We want this documented both for the patch release, where the feature is optional (default off), as well as for a later release, where the feature becomes default on. |
@Patater Why do you want to keep this when the feature is not optional? Perhaps we should modify the file how to opt-out features, which will be turned on by default. @AnotherButler Since this is specific for the cryptocell porting, I don't see a reason why to put this in our published docs, unless:
|
FYI @iriark01 |
@yanesca can you take a look at this in Jaeden's absence please? |
I agree with @Patater that it is best to keep this around. The user might want either hardware acceleration or full functionality. Whichever is the default, we should explain how to achieve the other. @RonEld you mention two ways to sync the readme with the default option in the source:
Which one would you like to do? |
I think the first option is prefered. The preceding PRs have been merged, and I think we should merge this PR. |
@RonEld When is the default going to change? How can we make it sure that we don't forget to update this documentation? |
My plan was that the PRs will be inserted to the patch releases, and for next major release, make default opted-in. Once this PR will be merged, I will make the PR changing the default in the modules, updating this documentation with it, targeting 2.15 |
They were integrated. @RonEld shall we progress here? |
CI started |
CI started |
Description
Add a section in the CC Readme file explaining how to enable the optional module.
Dependent on #10907 , #10913 , #10947
Pull request type
Reviewers
@ARMmbed/mbed-os-crypto
Release Notes