Skip to content

Disable mbed 2 and unsupported targets #12984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2020
Merged

Disable mbed 2 and unsupported targets #12984

merged 2 commits into from
May 18, 2020

Conversation

MarceloSalazar
Copy link

@MarceloSalazar MarceloSalazar commented May 15, 2020

Summary of changes

Mbed 2 targets are not expected to be supported on master and for the Mbed OS 6 release.
The following changes are introduced:

  • Remove "2" from release_versions as there is no Mbed 2 and these targets won't work as such
  • Remove LPC11U68 and KL27Z from targets.json as these are Mbed 2 only. They require migration to Mbed OS 6 Baremetal and can be introduced in the future.
  • Remove MAX32620HSP as there is no release_versions and is considered unsupported - see Maxim targets are not currently enabled #11233

Impact of changes

These targets continue to be available in the 5.15 branch.
Mbed OS 6 won't support these targets unless are re-introduced.

Migration actions required

none

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom
Copy link
Member

@MarceloSalazar, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels May 16, 2020
@0Grit
Copy link

0Grit commented May 16, 2020

Been waiting for this one for years. Great work everybody!

@0xc0170
Copy link
Contributor

0xc0170 commented May 18, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 18, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@jeromecoutant
Copy link
Collaborator

* Remove "2" from release_versions as there is no Mbed 2 and these targets won't work as such

Hi
Why don't you remove all release_versions. It looks OK for STM32 targets...?

@0xc0170
Copy link
Contributor

0xc0170 commented May 18, 2020

@jeromecoutant That will come but tools need some fixing as well to get this in (another PR is fixing part of the problem)

@0xc0170 0xc0170 merged commit 475621c into ARMmbed:master May 18, 2020
@mergify mergify bot removed the ready for merge label May 18, 2020
@MarceloSalazar MarceloSalazar deleted the dissable_mbed2_only branch May 18, 2020 07:35
@MarceloSalazar
Copy link
Author

FYI @ARMmbed/team-nxp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants