Skip to content

STM32H7 update drivers version to CUBE V1.8.0 #13690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2020
Merged

STM32H7 update drivers version to CUBE V1.8.0 #13690

merged 5 commits into from
Oct 20, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

ST Cube drivers version is updated from V1.7.0 to V1.8.0
which is the latest official version from:

https://github.com/STMicroelectronics/STM32CubeH7/

@ARMmbed/team-st-mcd

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

Tested by ST CI

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 30, 2020
@ciarmcom ciarmcom requested a review from a team September 30, 2020 16:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@jeromecoutant jeromecoutant mentioned this pull request Oct 5, 2020
Merged
@jeromecoutant jeromecoutant force-pushed the PR_H7_180 branch 2 times, most recently from 86f742f to b972282 Compare October 8, 2020 08:46
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2020

I restarted Travis

@0xc0170 0xc0170 closed this Oct 14, 2020
@mergify mergify bot removed needs: review release-type: patch Indentifies a PR as containing just a patch labels Oct 14, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2020

Travis did not catch the latest commit again (if you notice this, please just amend the last commit or rebase), it will restart the Travis job.

I'll reopen and review meanwhile

@0xc0170 0xc0170 added needs: review release-type: patch Indentifies a PR as containing just a patch labels Oct 14, 2020
@0xc0170 0xc0170 reopened this Oct 14, 2020
0xc0170
0xc0170 previously approved these changes Oct 14, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Oct 14, 2020
@adbridge
Copy link
Contributor

@0xc0170 what is happening with these licence checks ?

@JojoS62
Copy link
Contributor

JojoS62 commented Oct 14, 2020

I have merged this branch into my test, but it gives a linker error:

c:/program files (x86)/gnu tools arm embedded/9 2019-q4-major/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld.exe: section .crash_data_ram VMA [20000298,20000397] 
overlaps section .data VMA [20000000,200009a7]
collect2.exe: error: ld returned 1 exit status

@jeromecoutant
Copy link
Collaborator Author

@JojoS62 which target ?

@JojoS62
Copy link
Contributor

JojoS62 commented Oct 14, 2020

@jeromecoutant a custom target based on MCU_STM32H7, but I have not set MBED_RAM_START. I've just seen that RAM_START needs to be supplied as a fix?

@jeromecoutant
Copy link
Collaborator Author

I've just seen that RAM_START needs to be supplied as a fix?

Need to add something like
https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L2610-L2613
?

But I don't see why there is a difference with that PR?

@JojoS62
Copy link
Contributor

JojoS62 commented Oct 14, 2020

yes, adding

        "mbed_rom_start": "0x08000000",
        "mbed_rom_size": "0x200000",
        "mbed_ram_start": "0x24000000",
        "mbed_ram_size": "0x80000",

fixed the linker error. I had removed this because the generated binary is blinky_application.elf instead of blinky.elf, but ram_start is different.
But this PR also does not fix my original issue with USB on the H743.

@jeromecoutant
Copy link
Collaborator Author

We could correct RAM value in https://github.com/ARMmbed/mbed-os/blob/master/tools/arm_pack_manager/index.json

@JojoS62
Copy link
Contributor

JojoS62 commented Oct 14, 2020

thanks. Now I use only the ram overrides and this will not create the blinky_application.elf.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

I restarted travis, only license check :/ If that does not help, we might want to rebase to restart

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

@jeromecoutant can you rebase? I updated travis, I've noticed just today t here was a missing status report for licence_check - not certain why it started failing just now. The latest master contains a fix for travis to not report status the way we used to.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

@jeromecoutant the other updates are in, this needs now rebase because of readme

@mergify mergify bot added needs: work and removed needs: CI labels Oct 19, 2020
@mergify
Copy link

mergify bot commented Oct 19, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@jeromecoutant
Copy link
Collaborator Author

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 20, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Oct 20, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit d418667 into ARMmbed:master Oct 20, 2020
@mergify mergify bot removed the ready for merge label Oct 20, 2020
@jeromecoutant jeromecoutant deleted the PR_H7_180 branch October 20, 2020 11:13
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeromecoutant @ciarmcom @0xc0170 @adbridge @JojoS62 @mbed-ci @mbedmain