Add Arduino Portenta H7 as target #13826

facchinm · 2020-10-28T15:28:12Z

Summary of changes

This PR series introduces the support for Arduino Portenta H7 .
The patchset has been split into independent PRs for an easier review.
#13816
#13817
~~#13863~~

/cc @pennam @pnndra

Impact of changes

Except the standalone TARGET_PORTENTA* content, some other files have been touched (all of them in separate commits).

In particular, COMPONENT_WHD has been made generic (any mbed target implementing SERIAL_FC can now compile it) but this could impact PSOC6 targets which used to configure it via Cypress HAL.

Migration actions required

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Test results attached (this branch build over #13863 )

report-13-11.zip

Reviewers

@jeromecoutant
@romanjoe (for the WHD patches)

ciarmcom · 2020-10-28T15:30:38Z

@facchinm, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-core please review.

0xc0170 · 2020-11-02T09:38:31Z

As this is a draft, I'll mark it as do not merge until the update provided.

Please review Travis license failures.

facchinm · 2020-11-02T10:42:36Z

Hi @0xc0170 ,
I pushed a fix ae8de08 for the licenses on Arduino original files.
However, scancode recognized other files to be missing the SPDX identifier or with a non permissive license.
These files are from ST / Cypress directly so I have no clue if they must remain as-is or if there's any other action I can do to make Travis pass.

0xc0170 · 2020-11-02T10:51:48Z

I've checked few, they are related to Permissive Binary License , scancode does not yet recognize it. I'll create an issue and we will fix it.

jeromecoutant · 2020-11-02T15:29:16Z

Hi
Maybe you could remove updates in COMPONENT_CYW43XXX from this PR?
and push a specific one for BLE with the BLE expert in review ?

targets/targets.json

targets/TARGET_STM/rtc_api.c

targets/TARGET_STM/gpio_irq_api.c

targets/TARGET_STM/USBPhy_STM32.cpp

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_PORTENTA_H7/PeripheralNames.h

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/system_clock.c

jeromecoutant · 2020-11-02T16:20:03Z

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_PORTENTA_H7/system_clock_override.c

+/******************************************************************************/
+/*            PLL (clocked by HSE) used as System clock source                */
+/******************************************************************************/
+uint8_t SetSysClock_PLL_HSE(uint8_t bypass, bool lowspeed)


Could you add some comment about this 2 speed mode ?
Thx

Sure, will do

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_PORTENTA_H7/system_clock_override.c

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_PORTENTA_H7/PeripheralPins.c

targets/TARGET_STM/gpio_irq_api.c

targets/TARGET_STM/mbed_overrides.c

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_PORTENTA_H7/system_clock_override.c

targets/TARGET_STM/mbed_overrides.c

ABOSTM

LGTM for dual core part

jeromecoutant

Will execute tests when I have HW!

connectivity/mbedtls/source/x509_crt.c

connectivity/netsocket/source/TLSSocketWrapper.cpp

mbed-ci · 2021-01-05T13:31:24Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

0xc0170 · 2021-01-05T13:39:32Z

All green now. The fix for gpio is in the cI as well. is there anything else oustanding here or ready for the last round of review?

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_PORTENTA_H7/CMakeLists.txt

facchinm · 2021-01-05T13:52:37Z

All green now. The fix for gpio is in the cI as well. is there anything else oustanding here or ready for the last round of review?

Ready! 💪

connectivity/drivers/emac/TARGET_STM/TARGET_STM32H7/TARGET_PORTENTA_H7/CMakeLists.txt

0xc0170 · 2021-01-05T14:32:46Z

CI restarted

mbed-ci · 2021-01-05T15:14:10Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

0xc0170 · 2021-01-05T15:49:38Z

I'll merge this now. Please send separate PR addressing the review coments.

Flydroid · 2022-03-22T18:16:20Z

Hi,
Is the support for Portenta H7 in mbed public? How can I compile an mbed program for the portenta h7?
In the targets.json the board has set the attribute public to false.

I'm running platformio and have added mbed as framework to the portenta_h7_m7.json board definiton (I know its a hack).
Platformio compiles fine a simple blink program and flashes it via DFU. However the program doesn't run (no blinking led) and no com port in windows.

Any advice appriciated!

jeromecoutant · 2022-03-23T08:11:35Z

Hi, Is the support for Portenta H7 in mbed public? How can I compile an mbed program for the portenta h7? In the targets.json the board has set the attribute public to false.

Yes, you can build an application for M7 core with PORTENTA_H7_M7, or M4 with PORTENTA_H7_M4:
https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L3478

Flydroid · 2022-03-23T13:43:18Z

Hi @jeromecoutant

I could now find the PORTENTA_H7_M7 in mbed studio and compile. Neither studio nor mbed online could detect the portenta while it is in bootloader mode, so flashing was not possible through mbed tools.

Interesting is also that https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L3478
sets mbed_rom_start": "0x08000000. while the arduino part sets it to 0x8040000 because the arduino bootloader sits at 0x08000000. See https://github.com/arduino/ArduinoCore-mbed/blob/master/variants/PORTENTA_H7_M7/linker_script.ld.
0x8040000 is also the adress where the binary is flashed through dfu.

I have verified that through adding a custom linker script in my platformio setup, where I then was able to get a simple blink code running, however some quirkyness remainded as no com port was available and the LEDs were not acting according to my code.

Should I make a new issue, rather than contiuing discoussion here?

jeromecoutant · 2022-03-23T14:31:56Z

Should I make a new issue, rather than contiuing discoussion here?

Yes, a new issue is always better

facchinm marked this pull request as draft October 28, 2020 15:28

ciarmcom added the release-type: feature label Oct 28, 2020

ciarmcom requested review from jeromecoutant and a team October 28, 2020 15:30

ciarmcom added the needs: review label Oct 28, 2020

facchinm force-pushed the portenta-mainline branch from be5bd8f to 7417773 Compare October 28, 2020 15:49

0xc0170 added the do not merge label Nov 2, 2020

0xc0170 mentioned this pull request Nov 2, 2020

scancode: missing our pbl license in scanning the licenses #13840

Closed

jeromecoutant reviewed Nov 2, 2020

View reviewed changes

ABOSTM suggested changes Nov 3, 2020

View reviewed changes

targets/TARGET_STM/gpio_irq_api.c Show resolved Hide resolved

targets/TARGET_STM/gpio_irq_api.c Outdated Show resolved Hide resolved

targets/TARGET_STM/gpio_irq_api.c Outdated Show resolved Hide resolved

jeromecoutant reviewed Nov 3, 2020

View reviewed changes

targets/TARGET_STM/mbed_overrides.c Outdated Show resolved Hide resolved

ABOSTM suggested changes Nov 3, 2020

View reviewed changes

targets/TARGET_STM/mbed_overrides.c Outdated Show resolved Hide resolved

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_PORTENTA_H7/system_clock_override.c Show resolved Hide resolved

facchinm force-pushed the portenta-mainline branch from 51cff23 to 74b6256 Compare November 3, 2020 11:59

ABOSTM suggested changes Nov 3, 2020

View reviewed changes

targets/TARGET_STM/mbed_overrides.c Outdated Show resolved Hide resolved

facchinm force-pushed the portenta-mainline branch 4 times, most recently from 48758cf to 8038a6c Compare November 4, 2020 13:32

ABOSTM approved these changes Nov 4, 2020

View reviewed changes

jeromecoutant reviewed Nov 4, 2020

View reviewed changes

connectivity/mbedtls/source/x509_crt.c Outdated Show resolved Hide resolved

connectivity/netsocket/source/TLSSocketWrapper.cpp Outdated Show resolved Hide resolved

facchinm mentioned this pull request Nov 5, 2020

STM32: allow HS USB endpoints and increase USB OTG_HS endpoints number #13816

Merged

facchinm force-pushed the portenta-mainline branch from 8038a6c to 1e9c5e9 Compare November 10, 2020 16:41

mergify bot added needs: work and removed needs: review labels Nov 11, 2020

0xc0170 added the needs: CI label Jan 5, 2021

0xc0170 added needs: review and removed needs: CI labels Jan 5, 2021

hugueskamba reviewed Jan 5, 2021

View reviewed changes

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_PORTENTA_H7/CMakeLists.txt Show resolved Hide resolved

cmake: STM32H7: enable PORTENTA* target

62b6cc9

facchinm force-pushed the portenta-mainline branch from 3961272 to 62b6cc9 Compare January 5, 2021 13:50

hugueskamba reviewed Jan 5, 2021

View reviewed changes

connectivity/drivers/emac/TARGET_STM/TARGET_STM32H7/TARGET_PORTENTA_H7/CMakeLists.txt Show resolved Hide resolved

0xc0170 approved these changes Jan 5, 2021

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jan 5, 2021

mergify bot added ready for merge and removed needs: CI labels Jan 5, 2021

0xc0170 merged commit d0cd5fa into ARMmbed:master Jan 5, 2021

mergify bot removed the ready for merge label Jan 5, 2021

facchinm mentioned this pull request Jan 7, 2021

Set preferred connection parameters arduino/ArduinoCore-mbed#75

Closed

pennam mentioned this pull request Jan 8, 2021

Add PORTENTA_H7 target board arduino/mbed-os#2

Closed

mbedmain added release-version: 6.7.0 Release-pending and removed release-type: feature Release-pending labels Jan 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Arduino Portenta H7 as target #13826

Add Arduino Portenta H7 as target #13826

facchinm commented Oct 28, 2020 •

edited

Loading

ciarmcom commented Oct 28, 2020

0xc0170 commented Nov 2, 2020

facchinm commented Nov 2, 2020

0xc0170 commented Nov 2, 2020

jeromecoutant commented Nov 2, 2020

jeromecoutant Nov 2, 2020

facchinm Nov 3, 2020

ABOSTM left a comment

jeromecoutant left a comment

mbed-ci commented Jan 5, 2021

0xc0170 commented Jan 5, 2021

facchinm commented Jan 5, 2021

0xc0170 commented Jan 5, 2021

mbed-ci commented Jan 5, 2021

0xc0170 commented Jan 5, 2021

Flydroid commented Mar 22, 2022

jeromecoutant commented Mar 23, 2022

Flydroid commented Mar 23, 2022

jeromecoutant commented Mar 23, 2022

Add Arduino Portenta H7 as target #13826

Add Arduino Portenta H7 as target #13826

Conversation

facchinm commented Oct 28, 2020 • edited Loading

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

ciarmcom commented Oct 28, 2020

0xc0170 commented Nov 2, 2020

facchinm commented Nov 2, 2020

0xc0170 commented Nov 2, 2020

jeromecoutant commented Nov 2, 2020

jeromecoutant Nov 2, 2020

Choose a reason for hiding this comment

facchinm Nov 3, 2020

Choose a reason for hiding this comment

ABOSTM left a comment

Choose a reason for hiding this comment

jeromecoutant left a comment

Choose a reason for hiding this comment

mbed-ci commented Jan 5, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

0xc0170 commented Jan 5, 2021

facchinm commented Jan 5, 2021

0xc0170 commented Jan 5, 2021

mbed-ci commented Jan 5, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

0xc0170 commented Jan 5, 2021

Flydroid commented Mar 22, 2022

jeromecoutant commented Mar 23, 2022

Flydroid commented Mar 23, 2022

jeromecoutant commented Mar 23, 2022

facchinm commented Oct 28, 2020 •

edited

Loading