Skip to content

CMake: Add support for OSPIF blockdevice #14078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2021
Merged

CMake: Add support for OSPIF blockdevice #14078

merged 2 commits into from
Jan 5, 2021

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 21, 2020 •
edited
Loading

Summary of changes

  • Add new CMake library target
  • Add CMakeLists.txt input file
  • Rename include directory from QSPIF to OSPIF.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba
Correct OSPIF include directory
dca2ec7 
The include directory was incorrectly named QSPIF.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 21, 2020
@ciarmcom ciarmcom requested review from a team December 21, 2020 13:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@hugueskamba hugueskamba changed the title Correct OSPIF include directory CMake: Add support for OSPIF blockdevice Dec 21, 2020
@hugueskamba hugueskamba requested a review from rajkan01 December 21, 2020 13:05
@hugueskamba hugueskamba mentioned this pull request Dec 21, 2020
Merged
@mergify mergify bot added needs: CI and removed needs: review labels Jan 4, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 5, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 9c0cfa9 into ARMmbed:master Jan 5, 2021
@mergify mergify bot removed the ready for merge label Jan 5, 2021
@hugueskamba hugueskamba deleted the hk_rename_ospif_include_dir branch January 5, 2021 12:00
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon Awaiting requested review from evedon

@LDong-Arm LDong-Arm Awaiting requested review from LDong-Arm

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @mbedmain