-
Notifications
You must be signed in to change notification settings - Fork 3k
B96B async serial #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B96B async serial #1493
Conversation
|
Test results are the same as they used to be in the previous branch. |
Can you share the output from this test :https://github.com/mbedmicro/mbed/blob/master/libraries/tests/utest/serial_asynch/serial_asynch.cpp ? |
|
||
while ((tmpstatus == HAL_UART_STATE_BUSY_TX) || (tmpstatus == HAL_UART_STATE_BUSY_TX_RX)){ | ||
tmpstatus = HAL_UART_GetState(&UartHandle); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this waiting for ? It looks like for uart tx transfer to be completed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. It's been removed and tested OK. Thanks for the review.
do not initialise dma tx/rx when it is not activated.
Adding Release_Canditate type and promote-build function to upload script
Flush errors and current data register at reading start Allow separate serial obj for TX and RX (= do not initialize [TX/RX]_DMA when not needed. Char_match: make it work with long buffers and return the correct position of the char_match.
do not initialise dma tx/rx when it is not activated.
Flush errors and current data register at reading start Allow separate serial obj for TX and RX (= do not initialize [TX/RX]_DMA when not needed. Char_match: make it work with long buffers and return the correct position of the char_match.
…into b96b_asyn_serial_new
Tests have passed. MBED_37 is failing on the complete F4 family, but it is not considered as blocking. |
UT_SERIAL_ASYNCH test passed using D1 (UART2) in Tx, and D4 (UART5) in RxThe difference is that the Rx transfer is not stopped when an error or a CHAR_MATCH occurs (because using DMA transfer). OK (8 tests, 8 ran, 28 checks, 0 ignored, 0 filtered out, 0 ms) {{success}}
Completed in 7.79 sec |
#if DEVICE_SERIAL_ASYNCH_DMA | ||
static void dma_irq(DMAName name, int id) | ||
{ | ||
// TO DO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO should specify what is left to do here
Requested by Martin: test is now failing, as B96B_F446VE gives RX_COMPLETE event on top of errors and Char_Match
No description provided.