Added lpc812 cocorico target #1688
Conversation
I hope this is the way to do it.
| self.is_disk_virtual = True | ||
| # ??? do I need a detect code? self.detect_code = ["1050"] | ||
| self.progen = { | ||
| "target":"CoCo-ri-Co!", # all characters acceptable? |
There was a problem hiding this comment.
all characters acceptable?
I recommend using lower case, and please add this target to progen.
??? do I need a detect code? self.detect_code = ["1050"]
Does this target provide mbed cmsis-dap interface?
There was a problem hiding this comment.
Thank you for your comments. Here are the quick answers:
- OK, I will switch to lowercase only.
- Yes, this target provides an mbed cmsis-dap interface. So do I need the self.detect code? If so, this code or another? If another, where to get it?
and please add this target to progen
What do you mean by that? What is progen? Where can I find it? How do I add a target to it?
Sorry for asking stupid questions, but I am totally in the dark here. I have read all sorts of porting documents, but maybe I missed one?
|
@ElektorLabs self.detect == BOARD_ID. Confusing I know. progen can be found here: porting docs need some love and we're working on it 👍 https://github.com/project-generator |
|
Can you please rebase your PR? |
Sorry for being dumb and all, but what does that mean? rebase my PR? It would be very helpfull if you could elaborate a bit. How do I put you people in verbose mode? Many thanks in advance. |
you sent this PR from your master. Means I would I can help out with it this time, should be quick. |
This is based on the #1688, updated to target.json file.
|
@ElektorLabs because of changes in the targets, I pulled your changes and applied them to the current codebase. I'll reference the new PR and mention you in the new PR, please test/review it |
I hope this is the way to do it. Is a detect code needed?