-
Notifications
You must be signed in to change notification settings - Fork 3k
Updates for CI #1760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Updates for CI #1760
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b40b527
Dont exclude tests from magical lists
6f56032
update default toolchain locations for windows pointing to latest sup…
aae3d23
Fixing build loop in build_release.py
bridadan e481b44
Merge pull request #1 from bridadan/build-release-fix
sg- ab404e9
Fixing incorrect target name in release script, preventing traceback …
bridadan 8931dbe
Merge pull request #2 from bridadan/incorrect-target-build-release
sg- 6153259
Breaking up the uploading of build/test results.
bridadan 04bca79
Merge pull request #3 from bridadan/break-up-upload
sg- 98ed7c5
remove default path to GCC. Setting takes priority to PATH so this br…
sg- 9b02a1b
revert is_supported chages in favor of alternative command line option
sg- File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This info is still pretty useful, even if we don't necessarily want to use it at times.
I'd suggest adding an option in
singletest.py
to ignore theis_supported
function here, but still keep the ability to use this info.I'd suggest adding the
--include-unsupported
option tosingletest.py
. That way we keep backward compatibility but we add the ability to build all tests. We'd simply just have to check for this option here: https://github.com/mbedmicro/mbed/blob/1f340445d5333b485923beb9a7216fc54a8efeb4/workspace_tools/test_api.py#L652If this sounds like a good option, then I'd suggest reverting the changes here (uncomment the commented code), merge the PR, and I can submit a change to
singletest.py