Add a serial transmission complete test #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bridadan @PrzemekWirkus please review |
| #include "test_env.h" | ||
|
|
||
| int main() { | ||
| Serial *pc = new Serial(USBTX, USBRX); |
There was a problem hiding this comment.
Is there any reason your create Serial object on heap?
There was a problem hiding this comment.
No indeed no specific reason.
I can make it global - so I will send an updated PR for this
|
+1 |
LMESTM
force-pushed
the
dev_new_serial_complete_test
branch
2 times, most recently
from
8720974 to
7aac210
Compare
|
Hi - I just rebased to get an updated status |
This automated test makes sure that the serial syncrhonous API ensures a full transmission before the function returns. The complete string sent by printf shall be completely transferred before printf returns and the sleep modes are called. mbed Issue ARMmbed#1849
LMESTM
force-pushed
the
dev_new_serial_complete_test
branch
from
7aac210 to
8cb46bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automated test makes sure that the serial
syncrhonous API ensures a full transmission before
the function returns. The complete string sent by
printf shall be completely transferred before printf
returns and the sleep modes are called.
mbed Issue #1849