-
Notifications
You must be signed in to change notification settings - Fork 3k
Update exporters to include and use mbed_conf.h #1964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a808b89
to
ec98a3b
Compare
def get_compile_options(self, defines, includes): | ||
opts = ['-D%s' % d for d in defines] + ['@%s' % self.get_inc_file(includes)] | ||
config_header = self.get_config_header() | ||
if config_header is not None: | ||
opts = opts + ['-include', config_header] | ||
opts = opts + self.get_conifg_option(config_header) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be self.get_config_option()? :) This is the problem the CI is complaining about.
thanks @screamerbg ! |
a7e7952
to
17483b0
Compare
@mbed-bot: TEST HOST_OSES=windows |
Merged build finished. No test results found. |
[Build 505] |
There's one PR to change the name of the config (#1968), we should wait to see what's the final name of the config header file. I'll fetch this and test locally. The CI tests results are good. |
|
||
# Add the configuration file to the target directory | ||
self.config_header = "mbed_conf.h" | ||
cfg.get_config_data_header(join(trg_path, self.config_header)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cfg is not defined in this context NameError: global name 'cfg' is not defined
. should be config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right. the rebase renamed it to config.
The uvision requires a fix, it does not use progen_flags() function, like the rest of exporters do, thus it does not get I exported to IAR, c_flags look good, not certain if preinclude should be together with mbed_conf, as this puts them on the lines in the misc options in the IDE : --preincludembed_conf.h
Plus now that we have this header file, Warning[Pe047]: incompatible redefinition of macro "UNITY_INCLUDE_CONFIG_H" C:\2\mbed-blinky-morpheus\projectfiles\iar\mbed_conf.h 10 -D is still present |
I think we need a new attribute for exporters, something like |
I can't push to this branch anymore. It's claiming that I don't have permission. |
We could. |
@theotherjimmy Please always use the forked branches. Anyway, seems like there was a change within the permission, I don't know :( The fastest way would be to use your own fork and replace this PR with a new one. |
discussion should follow on #1975 |
[Exporters] Update exporters to include and use mbed_conf.h (Was #1964)
Affected exporters: