[STM32XX] Fix timer interrupt handler #2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +82,7 @@ HAL_StatusTypeDef HAL_InitTick(uint32_t TickPriority) { | |||
| // Configure time base | |||
| TimMasterHandle.Instance = TIM_MST; | |||
| TimMasterHandle.Init.Period = 0xFFFFFFFF; | |||
| TimMasterHandle.Init.Prescaler = (uint32_t)(SystemCoreClock / 1000000) - 1; // 1 �s tick | |||
| TimMasterHandle.Init.Prescaler = (uint32_t)(SystemCoreClock / 1000000) - 1; // 1 �s tick | |||
There was a problem hiding this comment.
can you use ascii character? 1 us tick or microsecond might be even better?
|
Is this ready to be merged? Both PR referenced here were integrated |
|
Rebase done and ready to merge. |
|
@mbed-bot: TEST HOST_OSES=windows |
|
[Build 579] |
|
I am getting stuck in while(1) loop in RTC_Alarm_IRQHandler while using Ethernet on STM32F746G Discovery board. Could it be related? |
|
The fix concern only the timer irq. To me, it can't be related. |
|
manually merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the targets use only the flag and some other only the interrupt source to check which channel of the master timer has triggered an interrupt in an interrupt handler.
The flag can be set by hardware even if the interrupt is disable and two interrupt can be enable, for one triggered, in the same handler so we need a double check here.
The major issue is that some
interrupt_xhandler code can be execute even if theinterrupt_xhave been disable.These commits make all of the st targets checking both int source and flag for the master timer.
Please merge this after these ones, I will rebase:
NUCLEO_F429ZINUCLEO_F446ZE