Test discovery refactor #2244
Merged
Test discovery refactor #2244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, test discovery throught test.py used its own logic to find tests. This was mostly a subset of the rules used during the build process. It respected .mbedignore files, but it did not respect TARGET_, TOOLCHAIN_, and FEATURES_ directories. This change now uses the same logic used during building to respect these folders. Tests under these folders that are not being pulled in for the given target will be ignored.
Also renaming 'target' variable to 'mcu' to match make.py
This was referenced Jul 25, 2016
|
LGTM. Please make sure that documentation is updated as well. May be file it as separate PR |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 527 Test failed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATUS: Ready - (Before merging, outside CLIs will need to be updated.)
NOTE: This is a breaking change for the
test.pyCLI.-mand-twill now be required arguments when--listis given. This is because the tests that are discovered are now dependent on the target and toolchain.This should address #2104.
Previously, test discovery throught test.py used its own logic to find tests. This was mostly a subset of the rules used during the build process. It respected .mbedignore files, but it did not respect TARGET_, TOOLCHAIN_, and FEATURES_ directories. This change now uses the same logic used during building to respect these folders. Tests under these folders that are not being pulled in for the given target will be ignored.
Please review @screamerbg
FYI @theotherjimmy @sg-