Fix RTC test for LPC and STM families on GCC #2302
Conversation
| #include "cmsis.h" | ||
| #include "CallChain.h" | ||
| #include "PlatformMutex.h" | ||
| #include "PlatformMutex.h" |
Move the PlatformMutex class into a dedicated file to reduce the number of unnecessary includes.
|
LGTM 👍 Lets run some tests! |
|
/morph test |
|
@mbed-bot: TEST HOST_OSES=windows |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 553 Build failed! |
Remove the critical section in mbed_rtc_time.c and instead use a mutex to protect this. This function does not need to be interrupt safe, just thread safe. This fixes crashes on the GCC_ARM toolchain on the RTC test due to trying to lock the GCC environment mutex while in a critical section. Prior to this patch, this failure was likely to occur on STM and LPC processor families.
|
[Build 734] |
|
/morph test |
|
@mbed-bot: TEST HOST_OSES=windows |
|
@c1728p9 Any chance you could throw a quick blurb in this PR's description so other people will know about these changes? Probably just copying your commit messages into it would be perfect. Thanks! |
|
Added a blurb |
|
[Build 735] |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 554 Test failed! |
Remove the critical section in mbed_rtc_time.c and instead use a
mutex to protect this. This function does not need to be interrupt
safe, just thread safe.
This fixes crashes on the GCC_ARM toolchain on the RTC test due to
trying to lock the GCC environment mutex while in a critical section.
Prior to this patch, this failure was likely to occur on STM and LPC
processor families.