Add jinja template for Callback class #2495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To workaround the lack of variadic arguments, multiple template specializations are declared for the Callback class based on the number of arguments. To avoid the tedious of updating the multiple declarations, the Callback class was ported to a jinja template, which is expanded on changes to the Callback class. Note: The generated Callback.h file is also committed, and jinja is not necessary to compile the Callback class. Using j2cli (https://pypi.python.org/pypi/j2cli/): j2 Callback.j2 > Callback.h
|
Is it possible to autogenerate the tests for the |
|
I'm going to merge this pr with #2496 to simplify things a bit and avoid confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To workaround the lack of variadic arguments, multiple template specializations are declared for the Callback class based on the number of arguments. This is not required in C++11.
To avoid the tedious of updating the multiple declarations, the Callback class was ported to a jinja template, which is expanded on changes to the Callback class.
Note: The generated Callback.h file is also committed, and jinja is not necessary to compile the Callback class.
Using j2cli (link):
j2 Callback.j2 > Callback.hLet me know what your thoughts are about including these files, if there is a better place for them, or if there is a different templating engine we should use.
cc @pan-, @0xc0170, @bogdanm