I2C byte read fix for Freescale platforms #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://mbed.org/questions/3181/Inconsistent-results-when-attempting-wri/ for the issue. Now every byte read is treated equal and ACKs/NACKs are correctly generated
Fixed also here single byte read (probably)
|
Hello Erik, Thanks! |
bridadan
pushed a commit
that referenced
this pull request
Jun 21, 2016
introduce tests for storage_abstraction and flash_journal
TomoYamanaka
pushed a commit
to TomoYamanaka/mbed-os
that referenced
this pull request
Dec 21, 2017
adbridge
pushed a commit
that referenced
this pull request
Dec 29, 2017
adbridge
pushed a commit
that referenced
this pull request
Jan 2, 2018
pan-
added a commit
to pan-/mbed
that referenced
this pull request
May 29, 2020
enable CI build 2 targets in parallel
ccli8
pushed a commit
to ccli8/mbed-os
that referenced
this pull request
Aug 13, 2024
…d#288) * Remove unavailable and EOLed target boards - Cypress/Infineon * Oops also update json files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single byte reads did not correctly ACK/NACK, that should be fixed with this.
K64F platform is untested, I don't expect issues, but needs a test :). Old code will by normal usage never reads with NACK, now it should correctly NACK the last byte (assuming of course you tell it to send a NACK). Or without logic analyzer, try this code: https://mbed.org/questions/3181/Inconsistent-results-when-attempting-wri/. If that works it should be fixed.
It also tells me the branches cannot be automatically merged. I don't know how I can see what the issue is, neither how I can fix it, so have fun ;).
Erik