-
Notifications
You must be signed in to change notification settings - Fork 3k
restructure - Restructure cmsis directory #2896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1042 All builds and test passed! |
Who do you want to review this, @geky? |
LGTM! This is awesome. |
@mbed-bot: TEST HOST_OSES=ALL |
/morph export-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gotta say, I really like the way this restructure looks 👍 I always thought the cmsis
folder was a bit weird. We'll have to wait and see what the mbed 2 bot says, but so far LGTM
[Build 1017] |
mbed 2 bot was not a happy camper. @geky Let me know if you need help reproducing |
targets/cmsis -> cmsis targets/cmsis/TARGET_* -> targets/TARGET_*/device targets/cmsis/TARGET_*/mbed_rtx.h -> targets/TARGET_*/mbed_rtx.h
a69864e
to
2be7207
Compare
@mbed-bot: TEST HOST_OSES=ALL |
/morph export-build |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
[Build 1018] |
The export test has no regressions as of this PR: #2898 @sarahmarshy's PR will need to be merged to get the export test back to passing: #2708 So exporter tests look ok 👍 |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1056 All builds and test passed! |
lots of failing CI. Still work in progress |
@mbed-bot: TEST HOST_OSES=ALL |
/morph test |
[Build ${MBED_BUILD_ID}] |
@mbed-bot: TEST HOST_OSES=ALL |
[Build 1020] |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1064 All builds and test passed! |
@geky Saw this failure from the mbed 2 bot: http://10.118.12.43:8080/job/mbed-2-build-and-run-tests_hw/5852/testReport/test.NUCLEO_F334R8.GCC_ARM/RTOS_4/Signals_messaging/ The important line is here: Is this a known issue? |
Some lingering restructure changes related to #2878.
TODO:
Reviews: