Skip to content

restructure - Restructure cmsis directory #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2016
Merged

Conversation

geky
Copy link
Contributor

@geky geky commented Oct 3, 2016

Some lingering restructure changes related to #2878.

targets/cmsis -> cmsis
targets/cmsis/TARGET_* -> targets/TARGET_*/device
targets/cmsis/TARGET_*/mbed_rtx.h -> targets/TARGET_*/mbed_rtx.h

TODO:

  • support mbed 5 builds
  • support mbed 2 builds
  • pass CI
  • pass review

Reviews:

@geky
Copy link
Contributor Author

geky commented Oct 3, 2016

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 4, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1042

All builds and test passed!

@theotherjimmy
Copy link
Contributor

theotherjimmy commented Oct 4, 2016

Who do you want to review this, @geky?
I was thinking @screamerbg would be a good idea.

@screamerbg
Copy link
Contributor

LGTM! This is awesome.

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

/morph export-build

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gotta say, I really like the way this restructure looks 👍 I always thought the cmsis folder was a bit weird. We'll have to wait and see what the mbed 2 bot says, but so far LGTM

@mbed-bot
Copy link

mbed-bot commented Oct 4, 2016

[Build 1017]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

mbed 2 bot was not a happy camper. @geky Let me know if you need help reproducing

geky added 3 commits October 4, 2016 17:51
targets/cmsis -> cmsis
targets/cmsis/TARGET_* -> targets/TARGET_*/device
targets/cmsis/TARGET_*/mbed_rtx.h -> targets/TARGET_*/mbed_rtx.h
@geky geky force-pushed the restructure-cmsis branch from a69864e to 2be7207 Compare October 4, 2016 23:08
@geky
Copy link
Contributor Author

geky commented Oct 4, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@geky
Copy link
Contributor Author

geky commented Oct 4, 2016

/morph export-build

@bridadan
Copy link
Contributor

bridadan commented Oct 4, 2016

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 5, 2016

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Oct 5, 2016

[Build 1018]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

bridadan commented Oct 5, 2016

The export test has no regressions as of this PR: #2898

@sarahmarshy's PR will need to be merged to get the export test back to passing: #2708

So exporter tests look ok 👍

@mbed-bot
Copy link

mbed-bot commented Oct 5, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1056

All builds and test passed!

@screamerbg
Copy link
Contributor

Is this ready for merge then @sg- @bridadan ?

@sg-
Copy link
Contributor

sg- commented Oct 5, 2016

lots of failing CI. Still work in progress

@geky
Copy link
Contributor Author

geky commented Oct 5, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@geky
Copy link
Contributor Author

geky commented Oct 5, 2016

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 5, 2016

[Build ${MBED_BUILD_ID}]
FAILURE: Something went wrong when building and testing.

@geky
Copy link
Contributor Author

geky commented Oct 5, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

mbed-bot commented Oct 5, 2016

[Build 1020]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

mbed-bot commented Oct 6, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1064

All builds and test passed!

@bridadan
Copy link
Contributor

bridadan commented Oct 6, 2016

@geky Saw this failure from the mbed 2 bot: http://10.118.12.43:8080/job/mbed-2-build-and-run-tests_hw/5852/testReport/test.NUCLEO_F334R8.GCC_ARM/RTOS_4/Signals_messaging/

The important line is here: mbed assertation failed: interrupts_disabled, file: C:\Jenkins\workspace\mbed-2-build-library\platform\mbed_critical.c, line 55 {{mbed_assert}}

Is this a known issue?

@sg- sg- merged commit eee4db1 into ARMmbed:master Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants