Modifying micro:bit pin names to mirror micro:bit edge connector #3176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….30} in PinNames.h Change-Id: I8d7ff6fe5ff5377f7ec8d3bc790dde0b0627f072
Change-Id: I0e080a30717ee0bcfa2db3f134acb08be851d767
Resolved issue: ARMmbed#2713 Removed pins p{0..30} definitions Defined pins P{0..20} as per micro:bit DAL's mappings: (https://github.com/lancaster-university/microbit-dal/blob/master/inc/drivers/MicroBitPin.h) Developers can now use the pin names as they appear on the mbed micro:bit pinout in https://developer.mbed.org/platforms/Microbit/#pinout Change-Id: I72b81dbe23b11d5ef215583adb211f364b4a5e91
|
retest uvisor |
|
@bremoran @jaustin @jamesadevine bump. |
|
This looks good to me, @jamesadevine may want to give it an 'okay' too :) |
|
Yeah, looks good to me! 😄 |
|
LGTM |
|
/morph test |
|
@mbed-bot: TEST HOST_OSES=ALL |
|
Thank you for all reviews. Waiting for CI results . |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1010 All builds and test passed! |
|
[Build 1091] |
aisair
pushed a commit
to aisair/mbed
that referenced
this pull request
Apr 30, 2024
Ports for Upcoming Targets Fixes and Changes 3127: Fixed the issue about push/pop of VFP register. ARMmbed/mbed-os#3127 3176: Modifying micro:bit pin names to mirror micro:bit edge connector ARMmbed/mbed-os#3176 3160: Fix wrong index at LPC43xx tx end ring assignment ARMmbed/mbed-os#3160 3217: Add I2C_ASYNCH capability for DISCO_F469NI ARMmbed/mbed-os#3217 3211: [NUC472/M453] Support single UART shared by multiple serial objects and other updates ARMmbed/mbed-os#3211 3198: NUCLEO_F410RB: Add I2C_ASYNCH capability ARMmbed/mbed-os#3198 3194: Update K64 sdk drivers ARMmbed/mbed-os#3194 3159: User trim values for NCS36510 ARMmbed/mbed-os#3159 3243: Fix make exporters compilation ARMmbed/mbed-os#3243 3231: STM32F3: DISCO_F303VC - Add missing UART and ADC pin muxing options ARMmbed/mbed-os#3231 3233: K20xx Calculate PWM clock relative to bus clock ARMmbed/mbed-os#3233 3237: Added back USART 6 pins ARMmbed/mbed-os#3237 3253: Fix default polarity on LPC43XX PWM driver ARMmbed/mbed-os#3253 3238: Dev i2c stm32f4hal ARMmbed/mbed-os#3238 3251: Dev stm32l0 cube v1.7.0 ARMmbed/mbed-os#3251 3252: [NORDIC - NRF51 - MBED 2] Fix non handled RTC IRQ ARMmbed/mbed-os#3252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Description
Modifying micro:bit pin names to mirror micro:bit edge connector, solving the issue #2713
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO | Only if pin names are used, API users should only make sure to conform to the new pin naming for the micro:bit, whereby p{0..30} (lowercase p) should be replaced with P0_{0..30} (uppercase P)
Related PRs
NONE
Todos
Deploy notes
Steps to test or reproduce