STM32F4 : map ST HAL assert into MBED assert #3391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
reviewed
Dec 8, 2016
| @@ -313,7 +313,7 @@ void gpio_irq_set(gpio_irq_t *obj, gpio_irq_event event, uint32_t enable) | |||
| mode = STM_MODE_IT_RISING; | |||
| obj->event = EDGE_RISE; | |||
| } else { // NONE or FALL | |||
| mode = STM_MODE_IT_EVT_RESET; | |||
| mode = STM_MODE_IT_RISING; | |||
There was a problem hiding this comment.
how is this connected to ST HAL assert? or any change in this commit?
There was a problem hiding this comment.
STM_MODE_IT_EVT_RESET is not a defined mode for ST HAL. We have to set a mode among possible values.
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Marking as |
|
@jeromecoutant Please amend the second commit for this one as well. thanks |
|
bump |
- RCC init: one PLL parameter was missing - GPIO: mode was not allowed by ST HAL API
jeromecoutant
force-pushed
the
PR_ST_F4_ASSERT
branch
from
a601d55 to
dd88e97
Compare
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
added
ready for merge
release-version: 5.3.2
and removed
needs: CI
ready for merge
labels
aisair
pushed a commit
to aisair/mbed
that referenced
this pull request
Apr 30, 2024
Ports for Upcoming Targets 3459: Target: Add new target UBLOX_EVK_NINA_B1 ARMmbed/mbed-os#3459 Fixes and Changes 3430: Fix ci shield eeprom test ARMmbed/mbed-os#3430 3381: STM32F1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3381 3389: STM32F2 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3389 3390: STM32F3 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3390 3410: STM32L4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3410 3422: Enable CAN on DISCO_F303VC ARMmbed/mbed-os#3422 3442: Dev stm i2c f1 ARMmbed/mbed-os#3442 3460: KSDK I2C: Update the return value to match the API documentation change ARMmbed/mbed-os#3460 3472: [RZ/A1H]Fix TTB setting of RO_DATA area ARMmbed/mbed-os#3472 3451: Rename KSDK2 to MCUXpresso. This is the new name of this package ARMmbed/mbed-os#3451 3391: STM32F4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3391 3454: STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files ARMmbed/mbed-os#3454 3489: NUCLEO_F103RB - Correct CAN and PWM alternate-functions ARMmbed/mbed-os#3489 3405: Repair the transmit mailbox (0,1,2) empty interrupt flag not clear BUG ARMmbed/mbed-os#3405 3502: MCUXpresso I2C: Handle 0 byte write ARMmbed/mbed-os#3502 3365: [NUC472/M453] Support USB device ARMmbed/mbed-os#3365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ST HAL assert is mapped onto MBED HAL assert, and can now be enabled easily.
Note for all STM32 targets:
Test
OS2 and OS5 tests done.
Few updates have been needed to match ST HAL API.
Status
READY