TARGET_NRF5: reworked i2c_api.c #3812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nvlsianpu @pan- @0xc0170 Could you take a look? |
|
@anangl Can you share the test results from CI? |
|
Here are the results: |
|
And for NRF51: |
0xc0170
requested changes
Feb 21, 2017
| nrf_delay_us(4); | ||
|
|
||
| for (int i = 0; i < 9; i++) | ||
| { |
There was a problem hiding this comment.
please fix the style as it is in the rest of the code for this function
|
Just small changes, the rest LGMT. will fire CI once addressed. Thanks for sharing the tests ! Always good to have as part of a patch! |
|
Just realized that CI tests have been updated since I cloned the repository. Here are the refreshed test results: |
0xc0170
approved these changes
Feb 21, 2017
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
i2c_api implementation has been changed in order to support single byte reads and writes (the latter are used in I2CEeprom module used in CI tests, and this caused that tests-i2c-api were failing). These operations (single byte transfers) are not possible to achieve with the driver from nrf5 SDK (nrf_drv_twi), so the new implementation uses TWI HAL only.
This PR addresses issue #3392, too.
Status
READY
Migrations
NO