feature_cmsis5: Fix mbedmicro-rtos-threads test for gcc 5.4. #3839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ARM compiler test results GCC 5.4: |
|
Can you share a map file for those 2 different versions of GCC ? I would like to make a diff to see why it increases? what about GCC 6? |
0xc0170
reviewed
Feb 24, 2017
| @@ -48,7 +48,10 @@ int main() | |||
| if (NULL == thread_list[i]) { | |||
| allocation_failure = true; | |||
| } | |||
| thread_list[i]->start(task_using_malloc); | |||
| else | |||
There was a problem hiding this comment.
please use the same formatting
nvlsianpu
force-pushed
the
feature_cmsis5
branch
from
8b7060f to
c7e556b
Compare
|
@0xc0170 map files were sent via e-mail. |
|
@nvlsianpu Could you fix the line which create the new threads ? With thread_list[i] = new (std::nothrow) Thread(osPriorityNormal, THREAD_STACK_SIZE); |
For gcc 5.4 each task consumes 0x128 B of stack.
nvlsianpu
force-pushed
the
feature_cmsis5
branch
from
c7e556b to
93c9a90
Compare
|
This PR fails to build for uvisor-tests http://e108747.cambridge.arm.com:8080/job/mbed-os/job/mbed-os-pr-uvisor-test-pipeline/1825/execution/node/116/log/ |
|
@bulislaw UVISOR requires a file named |
|
Ignore all the failures from the CIs. The uVisor support is not yet in (there's PR open). We'll update GCC to v6 soon in the CIs so all the issues will go away. @nvlsianpu Thanks for that, I'll check locally if changing stack size doesn't break other boards and merge. |
bulislaw
changed the title
|
I had a look and this PR actually makes the test fail for the GCC6. |
|
Now both NRF51 and NRF52 pass all the tests for GCC and ARM. Thanks for your help. I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For gcc 5.4 each task created into this test consumes 0x128 B of stack. for gcc 4.9 consumption was 0xA0 B. Increase the THREAD_STACK_SIZE fixed the problem.
Status
READY
Related to Issue
#3690