Replace CMSIS flash driver by SDK flash driver #4066

adustm · 2017-03-28T21:45:24Z

Description

Replace CMSIS flash driver by SDK flash drive

Status

+-------------------+---------------+----------------------+--------+--------------------+-------------+
| target            | platform_name | test suite           | result | elapsed_time (sec) | copy_method |
+-------------------+---------------+----------------------+--------+--------------------+-------------+
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_hal-flash | OK     | 21.13              | shell       |
+-------------------+---------------+----------------------+--------+--------------------+-------------+
mbedgt: test suite results: 1 OK
mbedgt: test case report:
+-------------------+---------------+----------------------+-------------------------------+--------+--------+--------+--------------------+
| target            | platform_name | test suite           | test case                     | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+----------------------+-------------------------------+--------+--------+--------+--------------------+
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_hal-flash | Flash - buffer alignment test | 1      | 0      | OK     | 2.13               |
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_hal-flash | Flash - clock and cache test  | 1      | 0      | OK     | 0.07               |
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_hal-flash | Flash - erase sector          | 1      | 0      | OK     | 1.15               |
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_hal-flash | Flash - init                  | 1      | 0      | OK     | 0.06               |
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_hal-flash | Flash - mapping alignment     | 1      | 0      | OK     | 0.06               |
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_hal-flash | Flash - program page          | 1      | 0      | OK     | 2.74               |
+-------------------+---------------+----------------------+-------------------------------+--------+--------+--------+--------------------+
+-------------------+---------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
| target            | platform_name | test suite                  | test case                 | passed | failed | result | elapsed_time (sec) |
+-------------------+---------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_drivers-flashiap | FlashIAP - init           | 1      | 0      | OK     | 0.05               |
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_drivers-flashiap | FlashIAP - program        | 1      | 0      | OK     | 3.09               |
| NUCLEO_F429ZI-ARM | NUCLEO_F429ZI | tests-mbed_drivers-flashiap | FlashIAP - program errors | 1      | 0      | OK     | 0.06               |
+-------------------+---------------+-----------------------------+---------------------------+--------+--------+--------+--------------------+

0xc0170 · 2017-03-29T09:00:42Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F429xI/device/flash_api.c

+        if (HAL_FLASH_Program(FLASH_TYPEPROGRAM_BYTE, address, (uint64_t)*data) != HAL_OK) {
+            return -1;
+        } else {
+            size--; address++;data++;


please one line at the time, split these to separate lines

ok, will do

0xc0170 · 2017-03-29T09:02:13Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F429xI/device/flash_api.c

+{
+  uint32_t sector = 0;
+
+  if((address < ADDR_FLASH_SECTOR_1) && (address >= ADDR_FLASH_SECTOR_0))


formatting:

if (cond) { } else { }

This functionality is not in the SDK driver ?

unfortunately not. I will rewrite this function

GetSector has been rewritten

0xc0170 · 2017-03-29T13:11:02Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F429xI/device/flash_api.c

+        tmp = address - ADDR_FLASH_SECTOR_12;
+    }
+    if (address < ADDR_FLASH_SECTOR_4) { // 16k sectorsize
+        //printf("tmp for sectors less than 4: 0X%4x")


shall this printf line be removed (dead code) ?

I removed it in the 2nd commit. I guess we've worked in //
:)

0xc0170 · 2017-03-29T13:11:42Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F429xI/device/flash_api.c

+    } else {
+        sector += 4 + (tmp >>17);
+    }
+    printf("address:0X%04x%04x, secteur: %d\n", (address>>16)&0XFFFF, (address&0XFFFF), sector);


Also this should not print always?

same comment. It's been removed in commitid= 09229

0xc0170 · 2017-03-29T15:16:50Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/device/flash_api.c

+    } else {
+        sector += 4 + (tmp >>17);
+    }
+    printf("address:0X%04x%04x, secteur: %d\n", (address>>16)&0XFFFF, (address&0XFFFF), sector);


here are still some printf , line 162 also?

sorry for that ! my eyes are not working properly today :)

0xc0170 · 2017-03-29T15:45:17Z

/morph test

mbed-bot · 2017-03-30T02:10:16Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1786

Build failed!

0xc0170 · 2017-03-30T09:35:56Z

@adustm Please look at the failures: http://mbedosci.cloudapp.net/results/pr/4066/1786/FAIL/UBLOX_EVK_ODIN_W2/GCC_ARM/build_log_UBLOX_EVK_ODIN_W2_GCC_ARM.txt

adustm · 2017-03-30T16:35:16Z

Hi,
UBLOX_EVK_ODIN_W2 is now compiling OK with GCC_ARM + IAR + ARM on commit 8B80b7a3

0xc0170 · 2017-03-30T16:39:23Z

/morph test

mbed-bot · 2017-03-30T21:07:02Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1800

All builds and test passed!

0xc0170 · 2017-04-03T09:35:55Z

retest uvisor

adustm · 2017-04-07T08:42:29Z

Hello @sg-, @0xc0170
Have you paid attention that this PR is merged to the workshop branch and not to the master ?
Kind regards
Armelle

0xc0170 · 2017-04-07T09:05:08Z

Have you paid attention that this PR is merged to the workshop branch and not to the master ?

Yes, we will integrate it to master

adustm added 3 commits March 28, 2017 23:39

Replase CMSIS flash driver by SDK flash driver

dfd0cf6

typo in flash_s struct

cb3907e

fix STM32F439 flash HAL

634df41

0xc0170 requested changes Mar 29, 2017

View reviewed changes

0xc0170 added the needs: work label Mar 29, 2017

adustm added 2 commits March 29, 2017 14:12

F429 + F439 : changes after code review

0d1c6c2

GetSector has been rewritten

remove debug printf

092297a

0xc0170 reviewed Mar 29, 2017

View reviewed changes

remove other printf debgu message

cd122f2

0xc0170 added needs: CI and removed needs: work labels Mar 29, 2017

Allow UBLOX to use SDK flash driver

8b80b7a

0xc0170 added needs: work and removed needs: CI labels Mar 30, 2017

0xc0170 approved these changes Mar 30, 2017

View reviewed changes

0xc0170 removed the needs: work label Mar 30, 2017

0xc0170 approved these changes Mar 30, 2017

View reviewed changes

0xc0170 added the ready for merge label Mar 31, 2017

sg- merged commit a52e1eb into ARMmbed:mbed-os-workshop-17q2 Apr 6, 2017

sg- removed the ready for merge label Apr 6, 2017

c1728p9 mentioned this pull request Jun 6, 2017

STM32L4 Flash support #4484

Merged

kegilbert mentioned this pull request Jun 6, 2017

Replace CMSIS flash driver by SDK flash driver #4485

Merged

adustm deleted the f429_sdk_flash_driver branch October 11, 2018 09:18

Replace CMSIS flash driver by SDK flash driver #4066

Replace CMSIS flash driver by SDK flash driver #4066

Uh oh!

Conversation

adustm commented Mar 28, 2017

Description

Status

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Mar 29, 2017

Uh oh!

mbed-bot commented Mar 30, 2017

Output

Uh oh!

0xc0170 commented Mar 30, 2017

Uh oh!

adustm commented Mar 30, 2017

Uh oh!

0xc0170 commented Mar 30, 2017

Uh oh!

mbed-bot commented Mar 30, 2017

Output

Uh oh!

0xc0170 commented Apr 3, 2017

Uh oh!

adustm commented Apr 7, 2017

Uh oh!

0xc0170 commented Apr 7, 2017

Uh oh!

Uh oh!