Skip to content

Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2017

Conversation

mmahadevan108
Copy link
Contributor

@mmahadevan108 mmahadevan108 commented May 9, 2017

Add support for NXP LPC54114 LPCXpresso board.

Status

READY

Related PRs

project-generator/project_generator_definitions#118
ARMmbed/mbed-ls#175
pyocd/FlashAlgo#31
ARMmbed/DAPLink#256

Tests

  • Pass mbed tests using ARM, GCC_ARM & IAR toolchain

@mmahadevan108
Copy link
Contributor Author

@mmahadevan108
Copy link
Contributor Author

cc @0xc0170 @sg- @jasonNXP @maclobdell

@0xc0170
Copy link
Contributor

0xc0170 commented May 11, 2017

@mmahadevan108 Please check travis - AssertionError: Target LPC54114_M4 contains invalid device_name LPC54114

@0xc0170
Copy link
Contributor

0xc0170 commented May 15, 2017

bump

@mmahadevan108
Copy link
Contributor Author

I have made the change to the target name.

@mmahadevan108
Copy link
Contributor Author

Below link has instructions on how to program DAPLink onto the LPCXpresso boards and binaries:
https://developer.mbed.org/teams/NXP/wiki/Updating-LPCXpresso-firmware

@0xc0170
Copy link
Contributor

0xc0170 commented May 16, 2017

retest uvisor

@@ -630,6 +630,19 @@
"release_versions": ["2", "5"],
"device_name": "MK82FN256xxx15"
},
"LPC54114": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldnt be better to name this LPCXpresso54114? and having lpc54114 for mcu (MCU_name) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This naming scheme is following what was done for other Freescale platforms. Also this name matches what is used in the mbed database.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which mbed database are you referring to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just talked to @maclobdell Offline, and he clarified the mbed database thing. @0xc0170 I think there is a (pretty arbitrary) restriction on target name length in the online compiler. LPC54114 is a pretty reasonable shortening of LPCXpresso54114.

@mmahadevan108 mmahadevan108 changed the title Add mbed support for LPCXpresso54114 board Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards May 17, 2017
@mmahadevan108
Copy link
Contributor Author

ARM has received LPC54608 boards, LPC54114 boards have not yet been delivered. I have updated this PR to include mbed-os support for LPC54608.

@mmahadevan108
Copy link
Contributor Author

LPC54608 test results.

LPC54608_IAR.txt
LPC54608_ARM.txt

@sg- sg- added needs: CI and removed needs: work labels May 18, 2017
@maclobdell
Copy link
Contributor

I received the LPC54114 and LPC54608 boards so we are able to test here locally also.

@adbridge
Copy link
Contributor

@0xc0170 @theotherjimmy Are you happy with the updates ? Do we need to run morph test or test-nightly on this ?

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2017

This should wait until cmsis5 integration (might require a small change to update and retest).

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2017

What does TARGET_LPC54114_M4/TOOLCHAIN_ARM_STD/keil_lib_power.ar do? Is there this archive only for armcc ?

@mmahadevan108
Copy link
Contributor Author

mmahadevan108 commented May 22, 2017

Yes this is the power library for armcc. There is a similar power library for IAR

@0xc0170
Copy link
Contributor

0xc0170 commented May 25, 2017

I received the LPC54114 and LPC54608 boards so we are able to test here locally also.

@studavekar Once this is in CI, please rerun tests, thanks

@sg-
Copy link
Contributor

sg- commented May 30, 2017

@mmahadevan108 Can you update the conflict?

@sg- sg- added needs: work and removed needs: CI labels May 30, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2017

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2017

retest uvisor

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2017

@mmahadevan108 Please can you resolve the conflict? We will restart CI

@theotherjimmy
Copy link
Contributor

@mmahadevan108 Bump. Could you resolve this conflict with a rebase?

1 similar comment
@theotherjimmy
Copy link
Contributor

@mmahadevan108 Bump. Could you resolve this conflict with a rebase?

@mmahadevan108 mmahadevan108 force-pushed the Add_LPC54114_Support branch from 7c0863f to 316b859 Compare July 20, 2017 18:31
@mmahadevan108
Copy link
Contributor Author

@theotherjimmy @0xc0170 I have rebased to the latest and rerun the tests.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 21, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 857

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 93ae6f9 into ARMmbed:master Jul 24, 2017
@mmahadevan108 mmahadevan108 deleted the Add_LPC54114_Support branch July 24, 2017 16:56
@sg-
Copy link
Contributor

sg- commented Jul 25, 2017

New board support without running exporter CI, risky!

@deepikabhavnani
Copy link

Yes this is the power library for armcc. There is a similar power library for IAR

@mmahadevan108 - Library libpower.a was added as part of this PR. Please share the purpose of this lib? What is it needed for and which test will break if this library is removed?

@mmahadevan108
Copy link
Contributor Author

This library is needed to set the SoC power settings for various core clock frequencies

@deepikabhavnani
Copy link

Thanks for the prompt response. I don't see any build issue with green tea with IAR 8.32 compiler (not tested on hardware), but will need confirmation from @ARMmbed/team-nxp if this library needs an update for new IAR version. Please see #9206 for more information.

@mmahadevan108
Copy link
Contributor Author

No update required.

@deepikabhavnani
Copy link

Thanks for the response 👍

@deepikabhavnani
Copy link

Also is it same for LPC546XX target as well? Currently the build fails for LPC546XX - #9207 so I am not sure of green tea build.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 4, 2019

This library is needed to set the SoC power settings for various core clock frequencies

@mmahadevan108 Can you send PR adding readme to describe the library and adding also license file if not present please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants