Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards #4290

mmahadevan108 · 2017-05-09T13:47:38Z

Add support for NXP LPC54114 LPCXpresso board.

Status

READY

Related PRs

project-generator/project_generator_definitions#118
ARMmbed/mbed-ls#175
pyocd/FlashAlgo#31
ARMmbed/DAPLink#256

Tests

Pass mbed tests using ARM, GCC_ARM & IAR toolchain

mmahadevan108 · 2017-05-09T13:48:15Z

LPC54114_IAR.txt
LPC54114_ARM.txt

mmahadevan108 · 2017-05-09T13:51:56Z

cc @0xc0170 @sg- @jasonNXP @maclobdell

0xc0170 · 2017-05-11T10:18:34Z

@mmahadevan108 Please check travis - AssertionError: Target LPC54114_M4 contains invalid device_name LPC54114

0xc0170 · 2017-05-15T15:33:37Z

bump

mmahadevan108 · 2017-05-15T16:41:12Z

I have made the change to the target name.

mmahadevan108 · 2017-05-15T19:45:19Z

Below link has instructions on how to program DAPLink onto the LPCXpresso boards and binaries:
https://developer.mbed.org/teams/NXP/wiki/Updating-LPCXpresso-firmware

0xc0170 · 2017-05-16T13:08:06Z

retest uvisor

0xc0170 · 2017-05-16T13:09:39Z

targets/targets.json

@@ -630,6 +630,19 @@
        "release_versions": ["2", "5"],
        "device_name": "MK82FN256xxx15"
    },
+    "LPC54114": {


wouldnt be better to name this LPCXpresso54114? and having lpc54114 for mcu (MCU_name) ?

This naming scheme is following what was done for other Freescale platforms. Also this name matches what is used in the mbed database.

Which mbed database are you referring to?

I just talked to @maclobdell Offline, and he clarified the mbed database thing. @0xc0170 I think there is a (pretty arbitrary) restriction on target name length in the online compiler. LPC54114 is a pretty reasonable shortening of LPCXpresso54114.

mmahadevan108 · 2017-05-17T14:20:12Z

ARM has received LPC54608 boards, LPC54114 boards have not yet been delivered. I have updated this PR to include mbed-os support for LPC54608.

mmahadevan108 · 2017-05-17T14:21:06Z

LPC54608 test results.

LPC54608_IAR.txt
LPC54608_ARM.txt

maclobdell · 2017-05-18T19:41:19Z

I received the LPC54114 and LPC54608 boards so we are able to test here locally also.

adbridge · 2017-05-22T09:44:34Z

@0xc0170 @theotherjimmy Are you happy with the updates ? Do we need to run morph test or test-nightly on this ?

0xc0170 · 2017-05-22T11:32:40Z

This should wait until cmsis5 integration (might require a small change to update and retest).

0xc0170 · 2017-05-22T13:02:21Z

What does TARGET_LPC54114_M4/TOOLCHAIN_ARM_STD/keil_lib_power.ar do? Is there this archive only for armcc ?

mmahadevan108 · 2017-05-22T16:58:58Z

Yes this is the power library for armcc. There is a similar power library for IAR

0xc0170 · 2017-05-25T13:43:55Z

I received the LPC54114 and LPC54608 boards so we are able to test here locally also.

@studavekar Once this is in CI, please rerun tests, thanks

sg- · 2017-05-30T21:32:56Z

@mmahadevan108 Can you update the conflict?

0xc0170 · 2017-06-28T12:14:52Z

/morph test

0xc0170 · 2017-06-28T12:15:02Z

retest uvisor

mbed-bot · 2017-06-28T21:39:43Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

0xc0170 · 2017-06-29T08:13:14Z

@mmahadevan108 Please can you resolve the conflict? We will restart CI

theotherjimmy · 2017-07-10T15:23:49Z

@mmahadevan108 Bump. Could you resolve this conflict with a rebase?

theotherjimmy · 2017-07-17T15:29:42Z

@mmahadevan108 Bump. Could you resolve this conflict with a rebase?

Signed-off-by: Mahadevan Mahesh <[email protected]>

mmahadevan108 · 2017-07-20T18:36:36Z

@theotherjimmy @0xc0170 I have rebased to the latest and rerun the tests.

0xc0170 · 2017-07-21T09:05:18Z

/morph test

mbed-bot · 2017-07-21T11:46:44Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 857

All builds and test passed!

sg- · 2017-07-25T11:47:35Z

New board support without running exporter CI, risky!

deepikabhavnani · 2019-01-03T22:38:30Z

Yes this is the power library for armcc. There is a similar power library for IAR

@mmahadevan108 - Library libpower.a was added as part of this PR. Please share the purpose of this lib? What is it needed for and which test will break if this library is removed?

mmahadevan108 · 2019-01-03T22:41:13Z

This library is needed to set the SoC power settings for various core clock frequencies

deepikabhavnani · 2019-01-03T22:55:27Z

Thanks for the prompt response. I don't see any build issue with green tea with IAR 8.32 compiler (not tested on hardware), but will need confirmation from @ARMmbed/team-nxp if this library needs an update for new IAR version. Please see #9206 for more information.

mmahadevan108 · 2019-01-03T22:57:45Z

No update required.

deepikabhavnani · 2019-01-03T22:59:10Z

Thanks for the response 👍

deepikabhavnani · 2019-01-03T23:00:50Z

Also is it same for LPC546XX target as well? Currently the build fails for LPC546XX - #9207 so I am not sure of green tea build.

0xc0170 · 2019-01-04T10:28:20Z

This library is needed to set the SoC power settings for various core clock frequencies

@mmahadevan108 Can you send PR adding readme to describe the library and adding also license file if not present please?

theotherjimmy added needs: review scope: new-target labels May 9, 2017

mmahadevan108 force-pushed the Add_LPC54114_Support branch from 67f18f2 to 6bd3d90 Compare May 10, 2017 20:54

0xc0170 added needs: work and removed needs: review labels May 15, 2017

mmahadevan108 force-pushed the Add_LPC54114_Support branch from 6bd3d90 to 308fae8 Compare May 15, 2017 16:40

maclobdell mentioned this pull request May 15, 2017

Add support for LPC54114 & LPC54608 ARMmbed/mbed-ls#175

Merged

0xc0170 reviewed May 16, 2017

View reviewed changes

mmahadevan108 changed the title ~~Add mbed support for LPCXpresso54114 board~~ Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards May 17, 2017

sg- added needs: CI and removed needs: work labels May 18, 2017

0xc0170 approved these changes May 22, 2017

View reviewed changes

sg- added needs: work and removed needs: CI labels May 30, 2017

theotherjimmy added needs: work and removed needs: CI labels Jun 29, 2017

mmahadevan108 added 4 commits July 20, 2017 13:15

Add mbed support for LPCXpresso54114 board

aee6f7b

Signed-off-by: Mahadevan Mahesh <[email protected]>

Add support for LPC54608

dfe2d3b

Signed-off-by: Mahadevan Mahesh <[email protected]>

LPC: Move platform specific code out of sleep api file

7d8b6d7

Signed-off-by: Mahadevan Mahesh <[email protected]>

LPC: Move platform specific code out of the analog api file

316b859

Signed-off-by: Mahadevan Mahesh <[email protected]>

mmahadevan108 force-pushed the Add_LPC54114_Support branch from 7c0863f to 316b859 Compare July 20, 2017 18:31

0xc0170 added ready for merge and removed needs: work labels Jul 21, 2017

theotherjimmy merged commit 93ae6f9 into ARMmbed:master Jul 24, 2017

theotherjimmy added release-version: 5.5.4 and removed ready for merge labels Jul 24, 2017

mmahadevan108 deleted the Add_LPC54114_Support branch July 24, 2017 16:56

Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards #4290

Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards #4290

Uh oh!

Conversation

mmahadevan108 commented May 9, 2017 • edited by theotherjimmy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status

Related PRs

Tests

Uh oh!

mmahadevan108 commented May 9, 2017

Uh oh!

mmahadevan108 commented May 9, 2017

Uh oh!

0xc0170 commented May 11, 2017

Uh oh!

0xc0170 commented May 15, 2017

Uh oh!

mmahadevan108 commented May 15, 2017

Uh oh!

mmahadevan108 commented May 15, 2017

Uh oh!

0xc0170 commented May 16, 2017

Uh oh!

0xc0170 May 16, 2017

Choose a reason for hiding this comment

Uh oh!

mmahadevan108 May 16, 2017

Choose a reason for hiding this comment

Uh oh!

theotherjimmy May 16, 2017

Choose a reason for hiding this comment

Uh oh!

theotherjimmy May 16, 2017

Choose a reason for hiding this comment

Uh oh!

mmahadevan108 commented May 17, 2017

Uh oh!

mmahadevan108 commented May 17, 2017

Uh oh!

maclobdell commented May 18, 2017

Uh oh!

adbridge commented May 22, 2017

Uh oh!

0xc0170 commented May 22, 2017

Uh oh!

0xc0170 commented May 22, 2017

Uh oh!

mmahadevan108 commented May 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented May 25, 2017

Uh oh!

sg- commented May 30, 2017

Uh oh!

0xc0170 commented Jun 28, 2017

Uh oh!

0xc0170 commented Jun 28, 2017

Uh oh!

mbed-bot commented Jun 28, 2017

Result: FAILURE

Uh oh!

0xc0170 commented Jun 29, 2017

Uh oh!

theotherjimmy commented Jul 10, 2017

Uh oh!

theotherjimmy commented Jul 17, 2017

Uh oh!

mmahadevan108 commented Jul 20, 2017

Uh oh!

0xc0170 commented Jul 21, 2017

Uh oh!

mbed-bot commented Jul 21, 2017

Result: SUCCESS

Output

Uh oh!

sg- commented Jul 25, 2017

Uh oh!

deepikabhavnani commented Jan 3, 2019

Uh oh!

mmahadevan108 commented May 9, 2017 •

edited by theotherjimmy

Loading

mmahadevan108 commented May 22, 2017 •

edited

Loading