-
Notifications
You must be signed in to change notification settings - Fork 3k
Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards #4290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mbed support for LPCXpresso54114 & LPCXpresso54608 boards #4290
Conversation
67f18f2
to
6bd3d90
Compare
@mmahadevan108 Please check travis - |
bump |
6bd3d90
to
308fae8
Compare
I have made the change to the target name. |
Below link has instructions on how to program DAPLink onto the LPCXpresso boards and binaries: |
retest uvisor |
targets/targets.json
Outdated
@@ -630,6 +630,19 @@ | |||
"release_versions": ["2", "5"], | |||
"device_name": "MK82FN256xxx15" | |||
}, | |||
"LPC54114": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldnt be better to name this LPCXpresso54114
? and having lpc54114 for mcu (MCU_name) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This naming scheme is following what was done for other Freescale platforms. Also this name matches what is used in the mbed database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which mbed database are you referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just talked to @maclobdell Offline, and he clarified the mbed database thing. @0xc0170 I think there is a (pretty arbitrary) restriction on target name length in the online compiler. LPC54114
is a pretty reasonable shortening of LPCXpresso54114
.
ARM has received LPC54608 boards, LPC54114 boards have not yet been delivered. I have updated this PR to include mbed-os support for LPC54608. |
LPC54608 test results. |
I received the LPC54114 and LPC54608 boards so we are able to test here locally also. |
@0xc0170 @theotherjimmy Are you happy with the updates ? Do we need to run morph test or test-nightly on this ? |
This should wait until cmsis5 integration (might require a small change to update and retest). |
What does |
Yes this is the power library for armcc. There is a similar power library for IAR |
@studavekar Once this is in CI, please rerun tests, thanks |
@mmahadevan108 Can you update the conflict? |
/morph test |
retest uvisor |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
@mmahadevan108 Please can you resolve the conflict? We will restart CI |
@mmahadevan108 Bump. Could you resolve this conflict with a rebase? |
1 similar comment
@mmahadevan108 Bump. Could you resolve this conflict with a rebase? |
Signed-off-by: Mahadevan Mahesh <[email protected]>
Signed-off-by: Mahadevan Mahesh <[email protected]>
Signed-off-by: Mahadevan Mahesh <[email protected]>
Signed-off-by: Mahadevan Mahesh <[email protected]>
7c0863f
to
316b859
Compare
@theotherjimmy @0xc0170 I have rebased to the latest and rerun the tests. |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
New board support without running exporter CI, risky! |
@mmahadevan108 - Library |
This library is needed to set the SoC power settings for various core clock frequencies |
Thanks for the prompt response. I don't see any build issue with green tea with IAR 8.32 compiler (not tested on hardware), but will need confirmation from @ARMmbed/team-nxp if this library needs an update for new IAR version. Please see #9206 for more information. |
No update required. |
Thanks for the response 👍 |
Also is it same for |
@mmahadevan108 Can you send PR adding readme to describe the library and adding also license file if not present please? |
Add support for NXP LPC54114 LPCXpresso board.
Status
READY
Related PRs
project-generator/project_generator_definitions#118
ARMmbed/mbed-ls#175
pyocd/FlashAlgo#31
ARMmbed/DAPLink#256
Tests