Skip to content

Disallow building of mbed OS 2 + RTOS, and remove mbed OS 5 support for Cortext-A #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2017

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented May 31, 2017

Description

I found my prior implementation of disabling Cortex-A unsatisfactory.
This PR actually fixes a long-standing bug: you can compile mbed OS 5 for mbed OS 2 only targets.

Todos

  • /morph test

@sg-
Copy link
Contributor

sg- commented Jun 1, 2017

@sg- sg- added needs: work and removed needs: CI labels Jun 1, 2017
@TomoYamanaka
Copy link
Contributor

@theotherjimmy

This PR seems that the below build error message is missed.
https://github.com/ARMmbed/mbed-os/pull/4415/files#diff-10c649f2fb1884b9dadbf45a6fe74e84L129

  • RZ_A1H Will be supported in mbed OS 5.6.
  • To use the RZ_A1H, please checkout the mbed OS 5.4 release branch.
  • See (LINK snip) for more information

Will you plan on reflecting these error messages after the test pass?

@theotherjimmy theotherjimmy changed the title Dissallow building of mbed OS 2 + RTOS and remove mbed OS 5 support for Cortext-A Disallow building of mbed OS 2 + RTOS, and remove mbed OS 5 support for Cortext-A Jun 1, 2017
@theotherjimmy theotherjimmy force-pushed the disable-2-builds branch 7 times, most recently from 692cf9a to 6ffd464 Compare June 1, 2017 15:56
@theotherjimmy
Copy link
Contributor Author

@sg- This should pass travis

@TomoYamanaka The message is now in.

@theotherjimmy
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Jun 1, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 47

All exports and builds passed!

@sg- sg- added needs: CI and removed needs: work labels Jun 1, 2017
@theotherjimmy
Copy link
Contributor Author

@sg- do we need a / morph test now?

@studavekar
Copy link
Contributor

/morph test

@mbed-bot
Copy link

mbed-bot commented Jun 2, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 410

Build Prep failed!

@studavekar
Copy link
Contributor

Failure because of Jenkins git plugin

Receiving objects: 62% (78356/125416), 108.26 MiB | 39.00 KiB/s
21:02:44 at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1799)
21:02:44 at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1525)
21:02:44 at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:65)

re-triggering
/morph test

@TomoYamanaka
Copy link
Contributor

@theotherjimmy

@TomoYamanaka The message is now in.

Thank you for contacting.
I confirmed the build error message. LGTM.

@mbed-bot
Copy link

mbed-bot commented Jun 2, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 412

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants