Fix rtc api time conversion #4499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ameba RTC driver converts time_t to second/minute/hour/day/month/year in rtc_write and back to time_t in rtc_read. Replace this with an implementation which uses time_t directly.
The use of mktime was causing a fault when called in interrupt handler because on GCC it lock the mutex protecting the environment, To overcome this issue, this patch add dedicated routine to convert a time_t into a tm and vice versa. In the process mktime has been optimized and is now an order of magnitude faster than the routines present in the C library.
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
retest uvisor |
|
@mazimkhan Can you help to restart uvisor for this patch (or might listen to my command few minutes later?) |
This field is necessary, it is used by several vendor RTC: Atmel, ST, NUVOTON, NXP.
This field is needed by the LPC43XX targets.
|
/morph test |
|
travis restarted, time limit reached (seeing it for the first time...) |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@jeromecoutant Please create a separate issue the next time, would help with readability and tracking this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of mktime and localtime from RTC drivers. This PR was taken from #4479 and expanded to cover all the targets since they have the same issue as ST devices. @pan- feel free to modify this as necessary.