-
Notifications
You must be signed in to change notification settings - Fork 3k
Enable crypto HW acceleration for STM32F437xG platforms #4898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
retest uvisor |
@yanesca Could you review |
retest uvisor |
@RonEld @andresag01 please review tihs addition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobMeades: Thanks for your contribution! The changes look good.
retest uvisor |
@yanesca, @0xc0170: There was a recent bug report for AES hardware acceleration on STM32F439xI: #4928. This PR looks good to me, but given that STM32F439xI and STM32F437xG share the same |
@RobMeades Can you confirm ? |
retest uvisor |
@0xc0170 I only ran the benchmarks from within mbed-os-example-tls and these seemed to run as expected. I can confirm, though, that the HW crypto source files are shared between all STM32F4 devices, so if there's an issue it should be common. |
@andresag01 , @yanesca, @0xc0170 : I've just tried running the tls-client example on this code and, with the change in #4934 not included, it returns:
This looks correct to me...? |
retest uvisor |
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
My current estimate is that I can start looking at this by the end of next week. |
retest uvisor |
@RobMeades Is that correct? You above test says otherwise. We are currently disabling AES for those platform until it's fixed. If they share the implementation, how come this one does not fail? @andresag01 I noticed you are happy with testing above, thus approved this addition? |
The HW crypto source files are certainly shared between all STM32F4 devices and I was able to pass the test. Maybe there is some other factor involved in causing the failure? |
that is what is unknown to me. To be certain, I would like to have one more test run on this target. @andresag01 @yanesca @RonEld What is your stand? Can you run quickly the test above on this platform to confirm the passing the test to accept this addition |
I am sorry, but I still need to review this before we can accept it and I am even more sorry that I couldn't review this yet. Unfortunately at this point I have no estimate when can I do the review, but I will do it as soon as I can! @RobMeades When you say that this has passed the test, do you mean compiling and successfully running on target the |
Well, it seems I was wrong. I've retrieved the latest https://github.com/ARMmbed/mbed-os-example-tls, made sure that
...and stops, while if I switch off HW crypto for AES it reports:
...and ends with "Hello world!" So I guess this is the issue reported in #4928. Over in #4928 I see that Martin comments: "The fix will get CI once CI is back running", but I can't see anything in the comments to indicate that there is a fix. If there is one in the pipeline, this PR can wait for it. If there is not, I will re-submit this PR with |
I suggest that we only merge this change once #5018 has been merged, I will update the description to clarify that. |
ARM Internal Ref: IOTSSL-1720 |
That PR was merged. What is remaining here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@RobMeades All good with this one, to trigger CI? |
Yup, should be no other dependencies. |
Build : FAILUREBuild number : 54 |
/morph build |
Build : SUCCESSBuild number : 118 Triggering tests/test mbed-os |
Test : SUCCESSBuild number : 58 |
This patch is now ready for integration |
Enable crypto HW acceleration for STM43F437xG platforms, i.e. ublox C030 family boards.
mbed-os-example-tls/benchmark/
before:....and after:
Test results for
mbed-os-tests-mbedtls-selftest
:NOTE: this should only be merged once PR #5018 (which fixes an AES HW crypto driver issue) has been merged.