Add MemoryPool test. #4936

mprse · 2017-08-18T09:51:12Z

Description

Add test for MemoryPool.

Status

READY

Migrations

No

bulislaw

There's couple of indentation errors. Also please split the PR into two commits: fixes to the original header and the tests.

bulislaw · 2017-08-18T10:05:17Z

rtos/MemoryPool.h

@@ -92,7 +96,7 @@ class MemoryPool : private mbed::NonCopyable<MemoryPool<T, pool_sz> > {
 private:
    osMemoryPoolId_t             _id;
    osMemoryPoolAttr_t           _attr;
-    char                         _pool_mem[sizeof(T) * pool_sz];
+    char                         _pool_mem[ ((sizeof(T) + 3) & ~3) * pool_sz];


Can we have a short comment why we are doing that.

bulislaw · 2017-08-18T10:09:09Z

rtos/MemoryPool.h

@@ -83,7 +84,10 @@ class MemoryPool : private mbed::NonCopyable<MemoryPool<T, pool_sz> > {

    /** Free a memory block.
      @param   block  address of the allocated memory block to be freed.
-      @return         status code that indicates the execution status of the function.
+      @return         osOK on successful deallocation, osErrorParameter if parameter mp_id


what is mb_id in our case? From the perspective of C++ API it doesn't exist. I don't think we should be quoting it, instead we could say something like internal error for both.

bulislaw · 2017-08-18T10:11:36Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+    return verbose_test_setup_handler(number_of_cases);
+}
+
+Case cases[] = {


Please fix the indentation.

bulislaw · 2017-08-18T10:13:48Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+ * When free operation is executed on this block again.
+ * Then operation fails with osErrorResource status.
+ */
+template<typename T, const uint32_t numOfEntries, AllocType atype>


That's way too long can you split it in multiple tests.

bulislaw · 2017-08-18T10:14:10Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+ * When free operation is executed on this block again.
+ * Then operation fails with osErrorResource status.
+ */
+template<typename T, const uint32_t numOfEntries, AllocType atype>


that's way too long can you split it in multiple small tests.

bulislaw · 2017-08-18T10:14:47Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+ * Then operation fails with osErrorResource status.
+ *
+ */
+template<typename T, AllocType atype>


That's too long can you please split it in multiple tests.

0xc0170 · 2017-08-21T12:06:45Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+ *
+ * */
+template<typename T, const uint32_t numOfEntries, AllocType atype>
+void test_mem_pool_alloc_success() {


starting { on the new line, below if also.
See https://docs.mbed.com/docs/mbed-os-handbook/en/5.1/cont/code_style/

@0xc0170 codding style has been updated.

0xc0170 · 2017-08-21T12:09:08Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+    T * p_blocks[numOfEntries];
+    uint32_t i;
+
+    /* Create a memory pool. */


It is good to have comments but I find a lot of them redundant . like create a memory pool, it is obvious from the code.

the comment on line 80 below for instance is fine.

0xc0170 · 2017-08-21T12:09:56Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+ * Then deallocation fails with osErrorParameter error.
+ *
+ */
+void free_block_invalid_prarameter_null() {


typo - parameter

bulislaw · 2017-08-23T15:31:05Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+ *
+ * Given MemoryPool object of the specified type and queue size has
+ * been successfully created.
+ * When max number of blocks is allocated form the pool.


typo -> from the pool

bulislaw · 2017-08-23T15:32:07Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+    T * p_blocks[numOfEntries];
+    uint32_t i;
+
+    p_mem_pool = new MemoryPool<T, numOfEntries>();


Why are you use dynamic allocation of the pool?

The intention was to not allocate lots of data on stack. In case when for example block size is equal to 12 bytes and pool consists of 100 blocks. In this case we would need over 1kB of memory for such memory pool. But then we agreed that such large numbers do not need to be tested. On the other hand why using dynamic allocation is a problem?

bulislaw · 2017-08-23T15:39:58Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+
+utest::v1::status_t test_setup(const size_t number_of_cases)
+{
+    GREENTEA_SETUP(45, "default_auto");


Can we go lower than 45 or is it actually as long as it takes?

Timeout has been modified to 20 s.

bulislaw · 2017-08-25T15:15:18Z

@0xc0170 can you have a look

/morph test

mbed-bot · 2017-08-25T18:09:28Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1119

Build failed!

0xc0170 · 2017-08-31T14:48:44Z

I restarted Travis, should become green. In case not, please close/opne the PR to restart travis. It sometimes does not report the status back

0xc0170 · 2017-08-31T14:49:59Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

+    if(object->a == 0 &&
+       object->b == 0 &&
+       object->c == 0)
+    {


please align this file according to https://docs.mbed.com/docs/mbed-os-handbook/en/latest/cont/code_style/

theotherjimmy · 2017-09-21T14:11:55Z

@0xc0170 Could you review please?

/morph test

mbed-bot · 2017-09-21T23:13:41Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1353

Build failed!

mprse · 2017-09-22T08:25:31Z

Output
mbed Build Number: 1353
Build failed!

One error on NUMAKER_PFM_NANO130 platform using IAR compiler: unable to allocate space for sections/blocks with a total estimated minimum size of 0x3b90 bytes (max align 0x8) in <[0x20000000-0x20003fff]> (total uncommitted space 0x3a00).

Test has been updated. Memory usage has been decreased.

@theotherjimmy could you please re-run morph test.

0xc0170 · 2017-09-22T08:46:52Z

There's couple of indentation errors. Also please split the PR into two commits: fixes to the original header and the tests.

Shall this be splitted as requested prior we run another CI?

mprse · 2017-09-22T09:08:38Z

Shall this be splitted as requested prior we run another CI?

This was my first PR and it initially provided two features:

fix in memory pool header file, and
memory pool test.

As requested this has been splitted into two PRs. Currently this PR provides only the test.
The header file has been fixed here:
#4941

mbed-ci · 2017-10-16T15:55:29Z

Build : FAILURE

Build number : 181
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4936/

mbed-ci · 2017-10-16T21:57:28Z

Test : FAILURE

Build number : 82
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/4936/82

0xc0170 · 2017-10-17T13:31:06Z

/morph test

mbed-ci · 2017-10-17T17:17:48Z

Test : FAILURE

Build number : 94
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/4936/94

0xc0170 · 2017-10-18T12:26:05Z

/morph build

mbed-ci · 2017-10-18T12:59:36Z

Build : FAILURE

Build number : 225
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4936/

0xc0170 · 2017-10-18T13:29:07Z

@mprse Please look at the latest build, there's linker error for one device.

mprse · 2017-10-19T05:45:56Z

Test : FAILURE

Build error on NUMAKER_PFM_NANO130/IAR:

Output: IAR ELF Linker V7.80.1.28/LNX for ARM
Output: Copyright 2007-2016 IAR Systems AB.
Output:
Output: 47 710 bytes of readonly code memory
Output: 4 481 bytes of readonly data memory
Output: 1 536 bytes of readwrite data memory
Output:
Output: Errors: 2
Output: Warnings: none
Output:
Output: Link time: 0.19 (CPU) 1.00 (elapsed)
Errors: Error[Lp011]: section placement failed
Errors: unable to allocate space for sections/blocks with a total estimated
Errors: minimum size of 0x3a28 bytes (max align 0x8) in
Errors: <[0x20000000-0x20003fff]> (total uncommitted space
Errors: 0x3a00).
Errors: Error[Lp021]: the destination for compressed initializer batch "P2-P3-1" is
Errors: placed at an address that is dependent on the size of the batch,
Errors: which is not allowed when using lz77 compression. Consider using
Errors: "initialize by copy with packing = zeros" (or none) instead.

Decreased memory usage by reducing number of test cases. Wrapper functions have been used to test alloc() and calloc() memory allocation types together (in one test case).
Hopefully this will solve the problem for time longer than two weeks.

adbridge · 2017-10-24T15:20:25Z

/morph uvisor-test

0xc0170 · 2017-10-25T21:42:13Z

/morph build

mbed-ci · 2017-10-25T22:10:13Z

Build : SUCCESS

Build number : 337
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4936/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-25T23:59:51Z

Test : SUCCESS

Build number : 150
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/4936/150

0xc0170 · 2017-10-26T14:24:06Z

@bulislaw Can you rereview after the update, tests are now green

0xc0170 · 2017-10-26T14:46:09Z

TESTS/mbedmicro-rtos-mbed/MemoryPool/main.cpp

@@ -0,0 +1,608 @@
+#include "mbed.h"


Can you please add the license header here, every file should have it

Licence header has been added.

bulislaw

Only the header is missing

Add test for MemoryPool.

0xc0170 · 2017-10-27T15:53:25Z

/morph build

mbed-ci · 2017-10-27T16:45:16Z

Build : SUCCESS

Build number : 360
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/4936/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-27T23:25:50Z

Test : SUCCESS

Build number : 173
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/4936/173

bulislaw suggested changes Aug 18, 2017

View reviewed changes

bulislaw added component: rtos needs: work labels Aug 18, 2017

mprse force-pushed the memPool_test_and_fixes branch 7 times, most recently from a22eb0c to 47ddbd2 Compare August 21, 2017 08:02

mprse changed the title ~~Add MemoryPool test and fixes in MemoryPool.h file.~~ Add MemoryPool test. Aug 21, 2017

0xc0170 reviewed Aug 21, 2017

View reviewed changes

mprse force-pushed the memPool_test_and_fixes branch from 47ddbd2 to e2323a7 Compare August 21, 2017 13:29

bulislaw suggested changes Aug 23, 2017

View reviewed changes

mprse force-pushed the memPool_test_and_fixes branch from e2323a7 to 03af8b5 Compare August 24, 2017 08:28

bulislaw approved these changes Aug 25, 2017

View reviewed changes

theotherjimmy added needs: CI and removed needs: work labels Aug 29, 2017

0xc0170 requested changes Aug 31, 2017

View reviewed changes

mprse force-pushed the memPool_test_and_fixes branch 2 times, most recently from db0aeff to f501fa2 Compare September 11, 2017 09:18

mprse force-pushed the memPool_test_and_fixes branch from f501fa2 to 8745845 Compare September 22, 2017 08:17

adbridge added needs: CI and removed needs: CI ready for merge labels Oct 16, 2017

mprse force-pushed the memPool_test_and_fixes branch 2 times, most recently from 1156e1e to 6f40a80 Compare October 23, 2017 13:34

0xc0170 reviewed Oct 26, 2017

View reviewed changes

bulislaw approved these changes Oct 26, 2017

View reviewed changes

Add MemoryPool test.

b7e2776

Add test for MemoryPool.

mprse force-pushed the memPool_test_and_fixes branch from 6f40a80 to b7e2776 Compare October 27, 2017 06:08

adbridge added ready for merge and removed needs: CI labels Oct 30, 2017

theotherjimmy merged commit 55197e7 into ARMmbed:master Oct 30, 2017

theotherjimmy added release-version: 5.6.4 and removed ready for merge labels Oct 30, 2017

Add MemoryPool test. #4936

Add MemoryPool test. #4936

Uh oh!

Conversation

mprse commented Aug 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Migrations

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mprse Aug 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bulislaw commented Aug 25, 2017

Uh oh!

mbed-bot commented Aug 25, 2017

Output

Uh oh!

0xc0170 commented Aug 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented Sep 21, 2017

Uh oh!

mbed-bot commented Sep 21, 2017

Output

Uh oh!

mprse commented Sep 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Sep 22, 2017

Uh oh!

mprse commented Sep 22, 2017

Uh oh!

mbed-ci commented Oct 16, 2017

Uh oh!

mbed-ci commented Oct 16, 2017

Uh oh!

0xc0170 commented Oct 17, 2017

Uh oh!

mbed-ci commented Oct 17, 2017

Uh oh!

0xc0170 commented Oct 18, 2017

Uh oh!

mbed-ci commented Oct 18, 2017

Uh oh!

mprse commented Aug 18, 2017 •

edited

Loading

mprse Aug 23, 2017 •

edited

Loading

mprse commented Sep 22, 2017 •

edited

Loading

mprse commented Oct 19, 2017 •

edited

Loading