Extends test set for Mail class #4945
Conversation
|
retest uvisor |
3 similar comments
|
retest uvisor |
|
retest uvisor |
|
retest uvisor |
|
@mazimkhan the uvisor seem to be stuck |
|
retest uvisor |
| { | ||
| Mail<uint32_t, 4> mail_box; | ||
|
|
||
| uint32_t start = us_ticker_read(); |
There was a problem hiding this comment.
Please use C++ API - there are tickers/timers etc, instead of using directly HAL
| When allocate/put/get/free memory block | ||
| Then all operations should succeed | ||
| */ | ||
| void test_uint32(void) |
There was a problem hiding this comment.
Can this duplication be avoided (template for instance) ? for uint_t 8,16,32 ?
maciejbocianski
force-pushed
the
mail_tests
branch
from
487887b to
54bf5e1
Compare
| const uint8_t id = mail->thread_id; | ||
|
|
||
| // verify thread id | ||
| result = result && (id == THREAD_1_ID); |
There was a problem hiding this comment.
Can we assert these here? So if it fails we know what actually went wrong.
| mail_box.free(mail); | ||
|
|
||
| if (result == false || ++result_counter == QUEUE_SIZE) { |
| When call @a get it returns previously put mails | ||
| Then mails should be in the same order as put | ||
| */ | ||
| void test_order(void) |
There was a problem hiding this comment.
Aren't we testing order in some other test?
There was a problem hiding this comment.
this is the only place where we test order intentionally
There was a problem hiding this comment.
+/** Test single thread Mail usage
+
+ Given mailbox and one additional thread
+ When messages are put in to the Mail box by this thread
+ Then messages are received in main thread in the same order as was sent and the data sent is valid
You're asserting the order here as well.
| uint32_t *mail3 = mail_box.alloc(); | ||
| TEST_ASSERT_NOT_EQUAL(NULL, mail3); | ||
|
|
||
| // 4 KO |
| uint32_t *mail4 = mail_box.alloc(); | ||
| TEST_ASSERT_NOT_EQUAL(NULL, mail4); | ||
|
|
||
| // 5 KO |
maciejbocianski
force-pushed
the
mail_tests
branch
3 times, most recently
from
70c12f2 to
dde0d55
Compare
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
@bulislaw can you check morph fail. Looks like some problem when building "startup_efm32wg.S" |
|
/morph test |
|
@bulislaw
|
|
You're in the queue, it'll take another couple of hours. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
| #include "rtos.h" | ||
| #include "us_ticker_api.h" |
There was a problem hiding this comment.
us ticker - not used anywhere?
| uint32_t *mail4 = mail_box.alloc(); | ||
| TEST_ASSERT_NOT_EQUAL(NULL, mail4); | ||
|
|
||
| // 5 KO |
There was a problem hiding this comment.
fifth should fail so "KO" is ok
maciejbocianski
force-pushed
the
mail_tests
branch
from
dde0d55 to
ae0b90f
Compare
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@tommikas Can you please restart jenkis CI (there is no link here) ? |
Description
New test suite for mail class
Status
READY
Requires
To pass Mail test following fix should be merged first: #4941