Add device_name for TB_SENSE_12. #5470

@theotherjimmy ..does this exporter failure above have something to do with .s and .S as seen in the past? the PR is only adding "device_name" to targets.json..

0xc0170 · 2017-11-10T12:07:02Z

/morph export-build

amq · 2017-11-10T13:48:11Z

There is one more target which needs device_name, both of them are covered in #5253

mbed-ci · 2017-11-10T13:58:42Z

Exporter Build : FAILURE

Build number : 109
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5470/

theotherjimmy · 2017-11-10T15:25:05Z

@ashok-rao Those extensions are only distinguished on POSIX, and uvision only runs on Windows. So, I hope not.

I have seen this before, but I don't recall what the solution was. I'll have to take a look in more detail on Monday.

ashok-rao · 2017-11-10T18:23:41Z

@theotherjimmy .. I see.. but I remember I had this issue on Windows some time back and I think others also faced this on their Windows machine.. Issue : #5145 .. Please let us know what you find on Monday! Thanks!

ashok-rao · 2017-11-13T18:00:26Z

@theotherjimmy @0xc0170 .. why is only uVision failing for this? I can see others are passing from Jenkins log...??

theotherjimmy · 2017-11-13T19:06:17Z

@ashok-rao This change only affects the Uvision Exporter. I would be surprised if others failed because of this.

0xc0170 · 2017-11-14T08:42:54Z

@ashok-rao Can you reproduce this issue locally please? Use export -t TB_SENSE_12 -i uvision

ashok-rao · 2017-11-14T10:03:34Z

Hi @0xc0170 . It seems to build fine on my local machine.. Steps I followed:
I cloned the latest master of Mbed OS:

C:\Ashok\blinky\mbed-os-example-blinky\mbed-os>git log
commit 1394bf95f19fdb0cbf569359bbac0b02efec5d87

Made the change..

then did mbed export :

C:\Ashok\blinky\mbed-os-example-blinky>mbed export -i uvision -m TB_SENSE_12 -vv
[mbed] Working path "C:\Ashok\blinky\mbed-os-example-blinky" (program)
[mbed] Exec "c:\python27\python.exe -u C:\Ashok\blinky\mbed-os-example-blinky\mbed-os\tools\project.py -i uvision -m TB_SENSE_12 --source ." in C:\Ashok\blinky\mbed-os-example-blinky
Scan: .

C:\Ashok\blinky\mbed-os-example-blinky>

And built it with MDK. I'm attaching build log below:
TB_SENSE_12_MDK_build_log.txt

Just checking if CI uses this version of ARMCC: Mine is this version:
*** Using Compiler 'V5.06 update 5 (build 528)', folder: 'C:\Keil_v5\ARM\ARMCC\Bin'

Edit:
Just checking the CI logs & it is using : *** Using Compiler 'V5.06 update 3 (build 300)', folder: 'C:\mbed_tools\Keil_v5\ARM\ARMCC\Bin' .
Does the compiler build version have anything to do with the .s and the .S failures?

0xc0170 · 2017-11-14T15:17:24Z

I would not suspect this is related to .s or .S files. __UVISION_VERSION should not be even present as uvisor is not supported for ARMCC.

I manually fetched this PR, and was able to build for uvision using exported project. After I installed the a pack for this device . 😕

theotherjimmy · 2017-11-14T15:17:29Z

Does the compiler build version have anything to do with the .s and the .S failures?

I don't recall, so it might.

theotherjimmy · 2017-11-14T15:19:14Z

@ashok-rao In general, it's more helpful to post code snippets in ``` blocks compared to screenshots. The advantage is that we can copy-paste from those blocks.

theotherjimmy · 2017-11-14T15:26:14Z

@0xc0170 I don't know what you're on about. The failure is in uVision, which, as far as I know, always emits that macro. the example that is failing is blinky. Where are you getting uvisor? it's just not present anywhere in the logs.

theotherjimmy · 2017-11-14T15:28:30Z

After I installed the a pack for this device

What error did you get before installing the pack for the device?

Everyone:
Do not claim you cannot reproduce the problem, after trying to build using the GUI. It may not do exactly the same thing as the batch build. Please use the batch build before you claim that you cannot reproduce the problem.

ashok-rao · 2017-11-14T17:33:36Z

@0xc0170 , same with me, I had to install the DFP for the EFR32MG12P332F1024xx125. Without the pack, MDK was selecting a generic M4_FP target & still builds succesfully. Not sure what you refer to regarding uvisor ?

@theotherjimmy , thanks for the note on screenshots, I just wanted to highlight the line numbers as well since targets.json has changed from my local copy to the latest master..so, just wanted to specify the line numbers where I made the change, hence the screenshot!
Attaching the batch file below that I generated from MDK (Under target options -> build -> generate batch file). It builds fine for me in the local system though & generates an AXF after successful build (I didn't convert that to bin)..
mbed-os-example-blinky.zip

theotherjimmy · 2017-11-14T17:46:07Z

@ashok-rao Then you could use a git diff, it would include line numbers. For example:

diff --git a/targets/targets.json b/targets/targets.json
index 0a8549f00..44eb9050c 100755
--- a/targets/targets.json
+++ b/targets/targets.json
@@ -2912,6 +2912,7 @@
     },
     "TB_SENSE_12": {
         "inherits": ["EFR32MG12P332F1024GL125"],
+        "device_name": "EFR32MG12P332F1024GL125",
         "device_has": ["ANALOGIN", "I2C", "I2CSLAVE", "I2C_ASYNCH", "INTERRUPTIN", "LOWPOWERTIMER", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SLEEP", "SPI", "SPISLAVE", "SPI_ASYNCH", "STDIO_MESSAGES", "TRNG", "FLASH"],
         "forced_reset_timeout": 5,
         "config": {

mine is also different, at line 2912 (between the @@). Even better, with a diff I can copy it to git am and git will apply it to my working copy. That said, I don't think line numbers matter much here...

Under target options -> build -> generate batch file

I don't think that's how CI runs the builds. The CI builds issuing the command in the build method. That may produce a different result than the method you used.

That being said, I would be surprised if it did.

ashok-rao · 2017-11-14T17:55:35Z

Thanks for the git diff notes! Will try to use where applicable.

Regarding batch files, I don't suspect either generation method would produce major differences though in the batch file generated. That being said, I don't have reach into the CI builds, so I cannot check that end. Someone with access could help us here!

cmonr · 2017-12-01T14:45:49Z

@ashok-rao I was just able to reproduce the error locally, and am now working to root cause the issue.

ashok-rao · 2017-12-01T15:47:45Z

Nice. Thank you @cmonr . Awaiting your inputs.

cmonr · 2017-12-01T20:16:56Z

@ashok-rao It looks like the issue is on our side, and will have to wait until Monday for a fix to be tested.

No action on your end is needed at the moment.

ashok-rao · 2017-12-11T15:17:43Z

@cmonr .. any news on this, please?

cmonr · 2017-12-11T16:52:31Z

@ashok-rao Looks like the modification made it in this weekend. I'm going to rerun the job to verify.

/morph export-build

mbed-ci · 2017-12-11T19:15:41Z

Exporter Build : FAILURE

Build number : 325
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5470/

kegilbert · 2017-12-11T19:49:37Z

/morph export-build

mbed-ci · 2017-12-11T20:55:35Z

Exporter Build : FAILURE

Build number : 327
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5470/

ashok-rao · 2017-12-12T08:25:03Z

?? Same error again..!! @cmonr ..

ashok-rao · 2017-12-15T09:47:42Z

@cmonr @kegilbert ..bump!

mbed-ci · 2017-12-15T16:16:56Z

Exporter Build : FAILURE

Build number : 356
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5470/

ashok-rao · 2017-12-15T16:41:55Z

Hmm, I don't see what failed here.. Looks like all tests have passed from the CI logs.. @0xc0170 @cmonr @kegilbert can you see what has failed?

kegilbert · 2017-12-15T17:30:40Z

We've been seeing some Jenkins related failures intermittently, sorry for the delay.
/morph export-build

cmonr · 2017-12-15T17:54:26Z

@ashok-rao I ran a limited manual build, and things finally look good on our side.

Barring any further strange Jenkins issues, this last build should do it!

mbed-ci · 2017-12-15T18:12:16Z

Exporter Build : FAILURE

Build number : 360
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5470/

ashok-rao · 2017-12-15T18:17:07Z

@cmonr @kegilbert .. crashed again!! And this time it's a different platform altogether.

kegilbert · 2017-12-15T18:18:46Z

This looks like an actual compilation error, running it by @geky since it looks like a filesystem error. That it only failed on that one platform makes me think it's another one-off error though...

kegilbert · 2017-12-15T20:05:28Z

My local compiler version is slightly off from the CI version but builds the export correctly. Trying again to see if it replicates and allocate the build node to debug further if it happens again.
/morph export-build

kegilbert · 2017-12-15T20:33:17Z

Offline static node got assigned, this time for real.
/morph export-build

mbed-ci · 2017-12-15T23:28:44Z

Exporter Build : SUCCESS

Build number : 362
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5470/

kegilbert · 2017-12-16T22:51:18Z

/morph build

mbed-ci · 2017-12-17T01:04:37Z

Build : SUCCESS

Build number : 709
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5470/

Triggering tests

/morph test

mbed-ci · 2017-12-17T02:30:49Z

Test : SUCCESS

Build number : 541
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5470/541

ashok-rao · 2017-12-17T18:51:50Z

Awesome! Finally..! @0xc0170 @adbridge ..over to you to take this PR further. Thank you @kegilbert @cmonr ..

kegilbert · 2017-12-18T16:54:26Z

No problem, sorry for the pain and delay @ashok-rao .

Adding device_name for TB_SENSE_12.

761254c

device_name key is required to add Cloud Client support / enable bootloader support for this target.

0xc0170 added the needs: CI label Nov 10, 2017

theotherjimmy changed the title ~~Adding device_name for TB_SENSE_12.~~ Add device_name for TB_SENSE_12. Nov 13, 2017

0xc0170 added needs: work and removed needs: CI labels Nov 14, 2017

0xc0170 added ready for merge and removed needs: work labels Dec 18, 2017

0xc0170 added the release-version: 5.7.1 label Dec 20, 2017

0xc0170 merged commit 9ebefcd into ARMmbed:master Dec 20, 2017

0xc0170 removed the ready for merge label Dec 20, 2017

Add device_name for TB_SENSE_12. #5470

Add device_name for TB_SENSE_12. #5470

Uh oh!

Conversation

ashok-rao commented Nov 9, 2017

Description

Status

Deploy notes

Uh oh!

ashok-rao commented Nov 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Nov 10, 2017

Uh oh!

stevew817 commented Nov 10, 2017

Uh oh!

mbed-ci commented Nov 10, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 10, 2017

Uh oh!

mbed-ci commented Nov 10, 2017

Uh oh!

stevew817 commented Nov 10, 2017

Uh oh!

ashok-rao commented Nov 10, 2017

Uh oh!

0xc0170 commented Nov 10, 2017

Uh oh!

amq commented Nov 10, 2017

Uh oh!

mbed-ci commented Nov 10, 2017

Uh oh!

theotherjimmy commented Nov 10, 2017

Uh oh!

ashok-rao commented Nov 10, 2017

Uh oh!

ashok-rao commented Nov 13, 2017

Uh oh!

theotherjimmy commented Nov 13, 2017

Uh oh!

0xc0170 commented Nov 14, 2017

Uh oh!

ashok-rao commented Nov 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Nov 14, 2017

Uh oh!

theotherjimmy commented Nov 14, 2017

Uh oh!

theotherjimmy commented Nov 14, 2017

Uh oh!

theotherjimmy commented Nov 14, 2017

Uh oh!

theotherjimmy commented Nov 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashok-rao commented Nov 14, 2017

Uh oh!

theotherjimmy commented Nov 14, 2017

Uh oh!

ashok-rao commented Nov 14, 2017

Uh oh!

cmonr commented Dec 1, 2017

Uh oh!

ashok-rao commented Dec 1, 2017

Uh oh!

cmonr commented Dec 1, 2017

Uh oh!

ashok-rao commented Dec 11, 2017

Uh oh!

cmonr commented Dec 11, 2017

Uh oh!

mbed-ci commented Dec 11, 2017

Uh oh!

kegilbert commented Dec 11, 2017

Uh oh!

mbed-ci commented Dec 11, 2017

Uh oh!

ashok-rao commented Dec 12, 2017

ashok-rao commented Nov 9, 2017 •

edited

Loading

ashok-rao commented Nov 14, 2017 •

edited

Loading

theotherjimmy commented Nov 14, 2017 •

edited

Loading

kegilbert commented Dec 15, 2017 •

edited

Loading

kegilbert commented Dec 15, 2017 •

edited

Loading