Skip to content

[K64F] Add mbed_mac_address implementation #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2014
Merged

[K64F] Add mbed_mac_address implementation #550

merged 1 commit into from
Oct 15, 2014

Conversation

sg-
Copy link
Contributor

@sg- sg- commented Oct 10, 2014

Currently the MAC for K64 is hardcoded and causes conflicts when multiple devices are on the same network. Downside is that to override this from an application $Sub$$ and $Super$$ need to be used but this seems reasonable. Seems like mbed_mac_address should be weakly defined for all SDK ports rather than in the mbed_common

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2014

To understand the proposal, mbed_interface code file contains implementation for mbed_mac_address(). And you propose to move it to mbed_override code file , target specific implementation.

Can you elaborate on "Downside is that to override this from an application $Sub$$ and $Super$$ need to be used but this seems reasonable. " ?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2014

The comment should be updated in the mbed_interface header file, shouldn't be?

/** This returns a unique 6-byte MAC address, based on the interface UID
 * If the interface is not present, it returns a default fixed MAC address (00:02:F7:F0:00:00)
 *
 * This is a weak function that can be overwritten if you want to provide your own mechanism to
 * provide a MAC address.
 *
 *  @param mac A 6-byte array to write the MAC address
 */
void mbed_mac_address(char *mac); 

@mbednotifications
Copy link

What should this be updated to? This is still a common file. I agree that
this implementation should change in general and each platform should
implement something that is semi-unique at the very least but there are
still a few platforms that use this a the default implementation namely the
Arch Pro, EA 4088 and MTS Gambit

On Mon, Oct 13, 2014 at 1:46 AM, Martin Kojtal [email protected]
wrote:

The comment should be updated in the mbed_interface header file.

/** This returns a unique 6-byte MAC address, based on the interface UID

  • If the interface is not present, it returns a default fixed MAC address (00:02:F7:F0:00:00)
    *
  • This is a weak function that can be overwritten if you want to provide your own mechanism to
  • provide a MAC address.
    *
  • @param mac A 6-byte array to write the MAC address
    */
    void mbed_mac_address(char *mac);


Reply to this email directly or view it on GitHub
#550 (comment).

You received this message because you are subscribed to the Google Groups
"mbed-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
For more options, visit https://groups.google.com/d/optout.

0xc0170 added a commit that referenced this pull request Oct 15, 2014
HAL: K64F - mbed_mac_address implementation
@0xc0170 0xc0170 merged commit 5d17b81 into ARMmbed:master Oct 15, 2014
@sg- sg- deleted the k64_uuid_mac branch October 21, 2014 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants