Fix for online mbed compiler fail for target REALTEK_RTL8195AM #5719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consistent with other tools
correct proprietary headers for some of our codes
also fix a minor building error
…tek/Lwipopts_conf.h to features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_Realtek/Lwipopts_conf.h
also reduce replicated code
also a minor fix to IAR icf file
correct heap size in icf file; improve REALTEK_RTL8195AM.py
right now still need to add flag in gcc.py, we are fixing!
…_imp2 CriticalSectionLock class improvement
As this is os tick implementation for rtos, it should not be compilied if rtos not present (mbed 2)
Travis: dsp only for cortex-m
Build api used to build cmsis separately (how mbed 2 is being build). This is currently not how cmsis is being defined. As there target dependencies in some cases, we should include paths from targets when building cmsis
Use mbed critical section
As it does not share the codebase with RZ A1H, it needs to be disabled until bring it up to date with the latest changes to cmsis. There are changes regarding caches, mmu and others
Renesas: fix cmsis lib build
|
@Archcady Can you rebase to get the latest changes (fixes travis) ? |
0xc0170
approved these changes
Jan 3, 2018
# Conflicts: # targets/TARGET_Realtek/TARGET_AMEBA/RTWInterface.cpp
…nto realtek-pr-oc
|
Rebased with master |
|
Please verify the commits on the branch, github shows plenty master commits here |
|
@ARMmbed/team-realtek |
…chcady/mbed-os into realtek-pr-oc"" This reverts commit 8420678.
|
Some issue with the branch, I shall make the changes and update this again. |
|
Due to issues with current branch, I shall re-create this PR on a new branch |
|
@samchuarm, @0xc0170 @adbridge, @theotherjimmy I have created a totally new PR for this #5794 which is rebased to latest mbed-os master. Would be great if that could be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
This pull request fixes the mbed online compile failure for the REALTEK_RTL8195AM device.
Description
The failure was caused due to a difference in the naming convention of object files generated by the online vs offline compiler.
The .sct file of the ARM compiler was modified to allow for seamless binary generation in both the online as well as offline compilers.
This PR is to fix the issue ARMmbed/mbed-os-example-blinky#102 and #5626
Status
READY
Migrations
Once this PR is merged, the online compilation should succeed
Related PRs
N/A
Todos
Deploy notes
No changes in build environment or tools required