-
Notifications
You must be signed in to change notification settings - Fork 3k
NXP: Add support for MIMXRT1050_EVK #5826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Below are the test results for the various toolchains: |
Below link has the interface firmware for MXRT1050_EVK |
Below is the PR to add mbed-ls support for iMXRT1050 EVK: |
int serial_writable(serial_t *obj) | ||
{ | ||
uint32_t status_flags = LPUART_GetStatusFlags(uart_addrs[obj->index]); | ||
if (status_flags & kLPUART_RxOverrunFlag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix formatting in this file, line 260 missing {
}
, line 252 also
line 125, and others
please review Travis failures (.s found and |
4a85f87
to
de711c8
Compare
I am not clear what the name failure is related. The board is called MXRT1050EVK with a processor MIMXRT1052. Hence the linker file name is different from the target name. |
It's related to cmsis pack. If this device does not have yet cmsis pack published, device_name should not be defined. If it is, seems that the name is not the one that is published (does not match hence the failure) |
There is a pack called MIMXRT1052_DFP available under Keil. Can you give more details on what should be matching? |
I can see locally to have this device name (from NXP.MIMXRT1052_DFP.2.3.0)
|
Perhaps the device name should be this? variant Dvariant="MIMXRT1052DVL6A" this was found below device Dname="MIMXRT1052xxxxx" in the NXP.MIMXRT1052_DFP.2.3.0.pack CMSIS Device Pack downloaded at http://www.keil.com/dd2/pack |
de711c8
to
e634dbd
Compare
I have change d the device_name to MIMXRT1052DVL6A and updated the PR. |
@maclobdell The error message says "Target MIMXRT1050_EVK contains invalid device_name MIMXRT1052DVL6A" |
@theotherjimmy @0xc0170 @maclobdell , can you provide some guidance on how to fix the build error. |
@mmahadevan108 I found the problem ,please follow this comment : #4608 (comment) We need to update our cached index to add the new device, this will resolve the build error |
@0xc0170 Thank you for looking into this. Please let me know if anything additional is needed for my end. |
@mmahadevan108 You need to update packs index as instructed in #4608 (comment) (and commit the update here). This should resolve the travis error |
dfbbacd
to
8c68c22
Compare
@0xc0170. I think I was able to move further. I am not clear on the reason for the current failures. |
Are you able to export now for uvision? I restarted travis and also jenkins |
Yes, I am able to export for uvision. |
There's travis error: "AssertionError: assert 'not found' in 'Not enough information in CMSIS packs to build a bootloader project'" From the code, it seems that these are missing:
@mmahadevan108 is this bug in the tools or cmsis pack? |
I am not very familiar with the cmsis packs that are generated. Below are the links for MXRT and K64. I don't see any mention of ROM in either of them. http://mcuxpresso.nxp.com/cmsis_pack/repo/NXP.iMXRT_DFP.pdsc |
Exporter Build : FAILUREBuild number : 658 |
@0xc0170 I am not clear on the failure |
@mmahadevan108 related to this changeset but our action this time, we will need to update the CI |
Test : FAILUREBuild number : 798 |
/morph export-build |
Exporter Build : FAILUREBuild number : 673 |
@studavekar Can you please check the latest exporters failure here? |
@mmahadevan108, we're currently working to resolve this on our side. Once it's resolved, we'll relaunch the export build. |
Something in |
@mmahadevan108, while we fix the exporter issue, could you take a look at the |
Have installed required pack for MIMXRT1050_EVK /morph export-build |
Exporter Build : SUCCESSBuild number : 694 |
@cmonr I am working with NXP SDK team to see how best to address this. Can we move ahead with this PR and I will submit a separate one to address that once I hear back from them. |
/morph build |
Build : SUCCESSBuild number : 1041 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 722 |
Test : SUCCESSBuild number : 848 |
Add support for iMXRT1050 EVK
Passed the mbed tests