Skip to content

NXP: Add support for MIMXRT1050_EVK #5826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

mmahadevan108
Copy link
Contributor

Add support for iMXRT1050 EVK

  • Tests
    Passed the mbed tests

@mmahadevan108
Copy link
Contributor Author

Below are the test results for the various toolchains:
MIMXRT_IAR.txt
MIMXRT_GCC_ARM.txt
MIMXRT_ARM.txt

@mmahadevan108
Copy link
Contributor Author

@mmahadevan108
Copy link
Contributor Author

mmahadevan108 commented Jan 10, 2018

cc @0xc0170 @maclobdell

@mmahadevan108
Copy link
Contributor Author

Below is the PR to add mbed-ls support for iMXRT1050 EVK:
ARMmbed/mbed-ls#290

int serial_writable(serial_t *obj)
{
uint32_t status_flags = LPUART_GetStatusFlags(uart_addrs[obj->index]);
if (status_flags & kLPUART_RxOverrunFlag)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix formatting in this file, line 260 missing { }, line 252 also

line 125, and others

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2018

please review Travis failures (.s found and MIMXRT1052xxxxx no yet in the pack?)

@mmahadevan108
Copy link
Contributor Author

I am not clear what the name failure is related. The board is called MXRT1050EVK with a processor MIMXRT1052. Hence the linker file name is different from the target name.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2018

I am not clear what the name failure is related. The board is called MXRT1050EVK with a processor MIMXRT1052. Hence the linker file name is different from the target name.

It's related to cmsis pack. If this device does not have yet cmsis pack published, device_name should not be defined. If it is, seems that the name is not the one that is published (does not match hence the failure)

@mmahadevan108
Copy link
Contributor Author

There is a pack called MIMXRT1052_DFP available under Keil. Can you give more details on what should be matching?
Is this a new check?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2018

I can see locally to have this device name (from NXP.MIMXRT1052_DFP.2.3.0)

<device Dname="MIMXRT1052xxxxx">

@theotherjimmy

@maclobdell
Copy link
Contributor

maclobdell commented Jan 17, 2018

Perhaps the device name should be this?

variant Dvariant="MIMXRT1052DVL6A"

this was found below device Dname="MIMXRT1052xxxxx" in the NXP.MIMXRT1052_DFP.2.3.0.pack CMSIS Device Pack downloaded at http://www.keil.com/dd2/pack

@mmahadevan108
Copy link
Contributor Author

I have change d the device_name to MIMXRT1052DVL6A and updated the PR.

@mmahadevan108
Copy link
Contributor Author

@maclobdell The error message says "Target MIMXRT1050_EVK contains invalid device_name MIMXRT1052DVL6A"

@mmahadevan108
Copy link
Contributor Author

@theotherjimmy @0xc0170 @maclobdell , can you provide some guidance on how to fix the build error.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2018

@mmahadevan108 I found the problem ,please follow this comment : #4608 (comment)

We need to update our cached index to add the new device, this will resolve the build error

@mmahadevan108
Copy link
Contributor Author

@0xc0170 Thank you for looking into this. Please let me know if anything additional is needed for my end.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2018

@mmahadevan108 You need to update packs index as instructed in #4608 (comment) (and commit the update here). This should resolve the travis error

@mmahadevan108
Copy link
Contributor Author

@0xc0170. I think I was able to move further. I am not clear on the reason for the current failures.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2018

@0xc0170. I think I was able to move further. I am not clear on the reason for the current failures.

Are you able to export now for uvision? I restarted travis and also jenkins

@mmahadevan108
Copy link
Contributor Author

Yes, I am able to export for uvision.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2018

There's travis error: "AssertionError: assert 'not found' in 'Not enough information in CMSIS packs to build a bootloader project'"

From the code, it seems that these are missing:

            rom_size = int(cmsis_part['memory']['IROM1']['size'], 0)
            rom_start = int(cmsis_part['memory']['IROM1']['start'], 0)

@mmahadevan108 is this bug in the tools or cmsis pack?

@mmahadevan108
Copy link
Contributor Author

I am not very familiar with the cmsis packs that are generated. Below are the links for MXRT and K64. I don't see any mention of ROM in either of them.

http://mcuxpresso.nxp.com/cmsis_pack/repo/NXP.iMXRT_DFP.pdsc
http://mcuxpresso.nxp.com/cmsis_pack/repo/NXP.FRDM-K64F_BSP.pdsc

@mbed-ci
Copy link

mbed-ci commented Jan 26, 2018

@mmahadevan108
Copy link
Contributor Author

@0xc0170 I am not clear on the failure
"cannot open source input file "__UVISION_VERSION SETA 521": No such file or directory"

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 26, 2018

@mmahadevan108 related to this changeset but our action this time, we will need to update the CI

@mbed-ci
Copy link

mbed-ci commented Jan 26, 2018

@cmonr
Copy link
Contributor

cmonr commented Jan 26, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 27, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2018

@studavekar Can you please check the latest exporters failure here?

@cmonr
Copy link
Contributor

cmonr commented Jan 29, 2018

@mmahadevan108, we're currently working to resolve this on our side.

Once it's resolved, we'll relaunch the export build.

@theotherjimmy
Copy link
Contributor

Something in fsl_clock.h for this target is not happy. It just makes 1MB of warnings on build.

@cmonr
Copy link
Contributor

cmonr commented Jan 29, 2018

@mmahadevan108, while we fix the exporter issue, could you take a look at the fsl_clock.h issue? The compiler output is throwing a large amount of warnings with this file.

Build log

@studavekar
Copy link
Contributor

Have installed required pack for MIMXRT1050_EVK

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 30, 2018

@mmahadevan108
Copy link
Contributor Author

@cmonr I am working with NXP SDK team to see how best to address this.

Can we move ahead with this PR and I will submit a separate one to address that once I hear back from them.

@cmonr
Copy link
Contributor

cmonr commented Feb 1, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2018

Build : SUCCESS

Build number : 1041
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5826/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants