Skip to content

ScopedLock implementation #5852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 6, 2018
Merged

ScopedLock implementation #5852

merged 4 commits into from
Feb 6, 2018

Conversation

maciejbocianski
Copy link
Contributor

@maciejbocianski maciejbocianski commented Jan 15, 2018 •
edited
Loading

Description

This PR is continuation of work done in #5420 related to scoped lock

It contains implementation of:

  • mbed::ScopedLock
  • rtos::ScopedMutexLock

Status

READY

Migrations

YES

Related PRs

#5420

@maciejbocianski maciejbocianski mentioned this pull request Jan 15, 2018
Closed
@maciejbocianski maciejbocianski changed the title Scoped lock ScopedLock implementation Jan 15, 2018
@maciejbocianski
Copy link
Contributor Author

Feel free to comment
@kjbracey-arm @0xc0170 @pan- @sg- @bulislaw

@0xc0170 0xc0170 requested review from sg- and SenRamakri January 15, 2018 14:48
Amanda Butler added 2 commits January 17, 2018 16:56
Copy edit ScopedLock.h
8f17560 
Copy edit document for active voice, present tense and consistent comma use.
Copy edit Mutex.h
1d35cce 
Copy edit document for active voice and consistent branding.
bulislaw
bulislaw reviewed Jan 19, 2018
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider it over-sufficiently reviewed.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

Build : SUCCESS

Build number : 900
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5852/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

Exporter Build : SUCCESS

Build number : 575
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5852/

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Jan 22, 2018

Test : SUCCESS

Build number : 746
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5852/746

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 24, 2018

Waiting for the final approval

@kjbracey kjbracey mentioned this pull request Jan 25, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Jan 26, 2018

Holding off until @SenRamakri and @sg- give feedback.

@cmonr cmonr merged commit 07fce41 into ARMmbed:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw left review comments

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

@SenRamakri SenRamakri SenRamakri approved these changes

@sg- sg- Awaiting requested review from sg-

Assignees
No one assigned
Labels
release-version: 5.8.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maciejbocianski @0xc0170 @mbed-ci @cmonr @bulislaw @pan- @kjbracey @SenRamakri