fatfs: Remove extra MBR block #6074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression after ChanFS update (here): Due to parameter changes in the f_mkfs function, the option to use a separate block for MBR (FDISK) was turned back on. This should be off (SFD) as it conflicts with an explicit MBR when using the MBRBlockDevice.
For more info see d1468a6
I also added a test that prevents this regression in the future, but at the moment it can't run in CI due to memory restrictions. (related: #6008, IOTMORF-2062)
cc @deepikabhavnani
should fix #5999