Skip to content

fatfs: Remove extra MBR block #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2018
Merged

fatfs: Remove extra MBR block #6074

merged 3 commits into from
Feb 14, 2018

Conversation

geky
Copy link
Contributor

@geky geky commented Feb 13, 2018

Regression after ChanFS update (here): Due to parameter changes in the f_mkfs function, the option to use a separate block for MBR (FDISK) was turned back on. This should be off (SFD) as it conflicts with an explicit MBR when using the MBRBlockDevice.

For more info see d1468a6

I also added a test that prevents this regression in the future, but at the moment it can't run in CI due to memory restrictions. (related: #6008, IOTMORF-2062)

cc @deepikabhavnani
should fix #5999

geky added 2 commits February 12, 2018 17:16
Regression after ChanFS update: Due to parameter changes in the f_mkfs
function, the option to use a separate block for MBR (FDISK) was turned
back on. This should be off as it conflicts with an explicit MBR when
using the MBRBlockDevice.
Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@geky
Copy link
Contributor Author

geky commented Feb 13, 2018

@deepikabhavnani, I also added a check for extended partitions just fyi

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2018

Build : SUCCESS

Build number : 1130
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6074/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2018

@cmonr cmonr merged commit 6c74dce into ARMmbed:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SD card FAT format with multipartitions are not compatible with PC
4 participants