-
Notifications
You must be signed in to change notification settings - Fork 3k
Generate/Link secure object file #6096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few style nits
tools/toolchains/gcc.py
Outdated
@@ -15,7 +15,7 @@ | |||
limitations under the License. | |||
""" | |||
import re | |||
from os.path import join, basename, splitext, dirname, exists | |||
from os.path import join, basename, splitext, dirname, exists, split |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this change is required. Could you remove it?
tools/toolchains/iar.py
Outdated
@@ -16,7 +16,7 @@ | |||
""" | |||
import re | |||
from os import remove | |||
from os.path import join, splitext, exists | |||
from os.path import join, splitext, exists, dirname |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is used, could you remove this change?
tools/toolchains/iar.py
Outdated
@@ -66,6 +66,7 @@ def __init__(self, target, notify=None, macros=None, | |||
cxx_flags_cmd = [ | |||
"--c++", "--no_rtti", "--no_exceptions" | |||
] | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this style change?
tools/toolchains/iar.py
Outdated
@@ -188,6 +195,7 @@ def link(self, output, objects, libraries, lib_dirs, mem_map): | |||
map_file = splitext(output)[0] + ".map" | |||
cmd = self.ld + [ "-o", output, "--map=%s" % map_file] + objects + libraries | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this style change?
Cortex v8 architecture based devices support secure/non-secure builds. Secure build should generate the object file/library from elf during link process which is used by non-secure binary during linking. --out-implib=file specifies output library in which symbols are exported --cmse-implib requests libraries mentioned above are secure gateway libraries Creation of secure library is done as part of linking process in GCC/ARMC6/IAR Non-Secure project should add this secure object file as part of the linking process. Secure library is named as cmse_lib.o.
a358eee
to
b21e93b
Compare
@theotherjimmy - Update the code with style fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
/morph build |
Build : SUCCESSBuild number : 1142 Triggering tests/morph test |
Re-triggering. |
Test : SUCCESSBuild number : 948 |
Exporter Build : SUCCESSBuild number : 817 |
Cortex v8 architecture based devices support secure/non-secure builds. Secure build should generate the object file/library from elf during link process which is used by non-secure binary during linking.
--out-implib=file specifies output library in which symbols are exported --cmse-implib requests libraries mentioned above are secure gateway libraries
Creation of secure library is done as part of linking process in GCC/ARMC6/IAR Non-Secure project should add this secure object file as part of the linking process.
Secure library is named as cmse_lib.o.