Skip to content

Generate/Link secure object file #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

deepikabhavnani
Copy link

Cortex v8 architecture based devices support secure/non-secure builds. Secure build should generate the object file/library from elf during link process which is used by non-secure binary during linking.

--out-implib=file specifies output library in which symbols are exported --cmse-implib requests libraries mentioned above are secure gateway libraries

Creation of secure library is done as part of linking process in GCC/ARMC6/IAR Non-Secure project should add this secure object file as part of the linking process.
Secure library is named as cmse_lib.o.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few style nits

@@ -15,7 +15,7 @@
limitations under the License.
"""
import re
from os.path import join, basename, splitext, dirname, exists
from os.path import join, basename, splitext, dirname, exists, split
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change is required. Could you remove it?

@@ -16,7 +16,7 @@
"""
import re
from os import remove
from os.path import join, splitext, exists
from os.path import join, splitext, exists, dirname
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is used, could you remove this change?

@@ -66,6 +66,7 @@ def __init__(self, target, notify=None, macros=None,
cxx_flags_cmd = [
"--c++", "--no_rtti", "--no_exceptions"
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this style change?

@@ -188,6 +195,7 @@ def link(self, output, objects, libraries, lib_dirs, mem_map):
map_file = splitext(output)[0] + ".map"
cmd = self.ld + [ "-o", output, "--map=%s" % map_file] + objects + libraries


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this style change?

Cortex v8 architecture based devices support secure/non-secure builds.
Secure build should generate the object file/library from elf during link
process which is used by non-secure binary during linking.

--out-implib=file specifies output library in which symbols are exported
--cmse-implib requests libraries mentioned above are secure gateway
libraries

Creation of secure library is done as part of linking process in GCC/ARMC6/IAR
Non-Secure project should add this secure object file as part of the
linking process.
Secure library is named as cmse_lib.o.
@deepikabhavnani
Copy link
Author

@theotherjimmy - Update the code with style fixes

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@deepikabhavnani
Copy link
Author

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2018

Build : SUCCESS

Build number : 1142
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6096/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Feb 14, 2018

Re-triggering.
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants