-
Notifications
You must be signed in to change notification settings - Fork 3k
Correct syntax for mbed export in Py3 #6192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this require #6200 to be resolved to have it fully tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes might have been split (removing debug messages, fixing syntax errors for python3).
@0xc0170 I fixed the python 3 syntax by removing the debug statements :3 |
501ef58
to
b677ec1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A feature that also doubles as a refactor.
Neat.
/morph build |
Build : SUCCESSBuild number : 1353 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 1007 |
Test : SUCCESSBuild number : 1135 |
@theotherjimmy Take a look at the Jenkins build jobs that failed. Many export jobs weren't even able to start properly. @studavekar Should the Jenkins jobs have even started considering the export step failed? |
An example failure Jenkins log:
|
@cmonr Those public logs are less than helpful. |
Isn't it part of exporter test? Feel free to change https://github.com/ARMmbed/mbed-os/blob/master/tools/test/examples/examples.py |
@theotherjimmy Still working on this PR? |
Yep! OOB Is time consuming. |
b677ec1
to
76a4c67
Compare
@cmonr Fixed yesterday. Review please. |
/morph build |
Build : SUCCESSBuild number : 1463 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 1108 |
Fyi:
|
I'll rebase. Just a sec. |
76a4c67
to
14255ca
Compare
Hmmmm. still present. |
Because a type was just |
28e8ea5
to
e5f5a3b
Compare
/morph build |
Build : SUCCESSBuild number : 1468 Triggering tests/morph test |
Test : FAILUREBuild number : 1238 |
Ignore this (^^^) test. It's from the first |
Exporter Build : SUCCESSBuild number : 1113 |
Test : SUCCESSBuild number : 1243 |
No description provided.