Skip to content

Correct syntax for mbed export in Py3 #6192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Conversation

theotherjimmy
Copy link
Contributor

No description provided.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2018

Does this require #6200 to be resolved to have it fully tested?

0xc0170
0xc0170 previously approved these changes Feb 26, 2018
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes might have been split (removing debug messages, fixing syntax errors for python3).

@theotherjimmy
Copy link
Contributor Author

@0xc0170 I fixed the python 3 syntax by removing the debug statements :3

cmonr
cmonr previously approved these changes Mar 6, 2018
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A feature that also doubles as a refactor.

Neat.

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2018

Build : SUCCESS

Build number : 1353
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6192/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

@theotherjimmy Take a look at the Jenkins build jobs that failed. Many export jobs weren't even able to start properly.

@studavekar Should the Jenkins jobs have even started considering the export step failed?

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

An example failure Jenkins log:

Started by upstream project "exporter-build-matrix" build number 1007
originally caused by:
 Started by upstream project "exporter-pipeline" build number 940
 originally caused by:
  GitHub pull request #6192 of commit b677ec1e1f34255f8cd902a52bdf9309a2b9fc1b, no merge conflicts.
[EnvInject] - Loading node environment variables.
[EnvInject] - Preparing an environment for the build.
[EnvInject] - Keeping Jenkins system variables.
[EnvInject] - Keeping Jenkins build variables.
[EnvInject] - Injecting contributions.
Building remotely on ec2-linux-exporter (i-0dc83ec12ad8df95e) (linux_exporter IAR linux_mbed_os_build ARM GCC_ARM) in workspace /builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse
[WS-CLEANUP] Deleting project workspace...
[ARCH_PRO_gnuarmeclipse] $ env bash /tmp/jenkins535171403212598430.sh
step : download sources...
build doesn't exists...
mkdir: cannot create directory ‘lockfile’: File exists
sources are been fetched by another process ...
waiting 100 sec for download to complete....
[ARCH_PRO_gnuarmeclipse] $ env bash /tmp/jenkins8274768685484174612.sh
Exporter build job
Extracting sources...
Extracting sources done..
[mbed] WARNING: Could not find mbed program in current path "/builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky".
[mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
---
usage: project.py [-h] [-m MCU] [-i IDE] [-c] [-p PROGRAM] [-n PROGRAM] [-b]
                  [-L] [-S [{matrix,ides}]] [-E] [--build BUILD_DIR]
                  [--source SOURCE_DIR] [-D MACROS] [--profile PROFILE]
                  [--update-packs] [--app-config APP_CONFIG]
project.py: error: argument -m/--mcu: invalid upper value: 'ARCH_PRO'
[mbed] ERROR: "/usr/bin/python" returned error code 2.
[mbed] ERROR: Command "/usr/bin/python -u /builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky/mbed-os/tools/project.py -i gnuarmeclipse -m ARCH_PRO --source ." in "/builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky"
---
[mbed] WARNING: Could not find mbed program in current path "/builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-sockets".
[mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
---
usage: project.py [-h] [-m MCU] [-i IDE] [-c] [-p PROGRAM] [-n PROGRAM] [-b]
                  [-L] [-S [{matrix,ides}]] [-E] [--build BUILD_DIR]
                  [--source SOURCE_DIR] [-D MACROS] [--profile PROFILE]
                  [--update-packs] [--app-config APP_CONFIG]
project.py: error: argument -m/--mcu: invalid upper value: 'ARCH_PRO'
[mbed] ERROR: "/usr/bin/python" returned error code 2.
[mbed] ERROR: Command "/usr/bin/python -u /builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-sockets/mbed-os/tools/project.py -i gnuarmeclipse -m ARCH_PRO --source ." in "/builds/ws/exporter-build-matrix/1007/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-sockets"
---
Completed 958 Bytes/958 Bytes (16.9 KiB/s) with 1 file(s) remaining
upload: ../../b677ec1e1f34255f8cd902a52bdf9309a2b9fc1b_exporter_build_log_ARCH_PRO_gnuarmeclipse.txt to s3://mbed-os/builds/exporter/6192/FAIL/ARCH_PRO/gnuarmeclipse/b677ec1e1f34255f8cd902a52bdf9309a2b9fc1b_exporter_build_log_ARCH_PRO_gnuarmeclipse.txt
upload of example bin failed
Build failed !!!
Build step 'Execute shell' marked build as failure
[BFA] Scanning build for known causes...
[BFA] No failure causes found
[BFA] Done. 0s
[WS-CLEANUP] Deleting project workspace...[WS-CLEANUP] done
Finished: FAILURE

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Mar 6, 2018

@cmonr Those public logs are less than helpful.

@studavekar
Copy link
Contributor

studavekar commented Mar 6, 2018

@studavekar Should the Jenkins jobs have even started considering the export step failed?

Isn't it part of exporter test? Feel free to change https://github.com/ARMmbed/mbed-os/blob/master/tools/test/examples/examples.py

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2018

@theotherjimmy Still working on this PR?

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Mar 15, 2018

Yep!


OOB Is time consuming.

@theotherjimmy
Copy link
Contributor Author

@cmonr Fixed yesterday. Review please.

cmonr
cmonr previously approved these changes Mar 16, 2018
@cmonr
Copy link
Contributor

cmonr commented Mar 16, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2018

Build : SUCCESS

Build number : 1463
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6192/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 16, 2018

Fyi:

12:04:30 usage: project.py [-h] [-m MCU] [-i IDE] [-c] [-p PROGRAM] [-n PROGRAM] [-b]
12:04:30                   [-L] [-S [{matrix,ides}]] [-E] [--build BUILD_DIR]
12:04:30                   [--source SOURCE_DIR] [-D MACROS] [--profile PROFILE]
12:04:30                   [--update-packs] [--app-config APP_CONFIG]
12:04:30 project.py: error: argument -m/--mcu: invalid upper value: 'ARCH_PRO'
12:04:30 [mbed] ERROR: "/usr/bin/python" returned error code 2.
12:04:30 [mbed] ERROR: Command "/usr/bin/python -u /builds/ws/exporter-build-matrix/1108/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky/mbed-os/tools/project.py -i gnuarmeclipse -m ARCH_PRO --source ." in "/builds/ws/exporter-build-matrix/1108/ARCH_PRO_gnuarmeclipse/sources/examples/mbed-os-example-blinky"
12:21:32 usage: project.py [-h] [-m MCU] [-i IDE] [-c] [-p PROGRAM] [-n PROGRAM] [-b]
12:21:32                   [-L] [-S [{matrix,ides}]] [-E] [--build BUILD_DIR]
12:21:32                   [--source SOURCE_DIR] [-D MACROS] [--profile PROFILE]
12:21:32                   [--update-packs] [--app-config APP_CONFIG]
12:21:32 project.py: error: argument -m/--mcu: invalid upper value: 'TY51822R3'
12:21:32 [mbed] WARNING: Could not find mbed program in current path "C:\builds\ws\exporter-build-matrix\1108\TY51822R3_iar\sources\examples\mbed-os-example-blinky".
12:21:32 [mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.

@theotherjimmy
Copy link
Contributor Author

I'll rebase. Just a sec.

@theotherjimmy
Copy link
Contributor Author

Hmmmm. still present.

@theotherjimmy
Copy link
Contributor Author

Because a type was just str.upper....

@cmonr
Copy link
Contributor

cmonr commented Mar 16, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2018

Build : SUCCESS

Build number : 1468
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6192/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 16, 2018

Ignore this (^^^) test. It's from the first build command.

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2018

Test : SUCCESS

Build number : 1243
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6192/1243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants