Rename DEVICE_LOWPOWERTIMER to DEVICE_LPTICKER #6351

bulislaw · 2018-03-13T17:41:36Z

Description

Rename DEVICE_LOWPOWERTIMER to DEVICE_LPTICKER to match DEVICE_USTICKER.

Pull request type

That's to match DEVICE_USTICKER.

0xc0170 · 2018-03-14T08:24:59Z

Travis failed for maxim target, looks related to this change

bulislaw · 2018-03-14T11:36:03Z

This test also fails on clean feature-hal-spec-rtc branch, I'll fix it.

…ct device_has

bulislaw · 2018-03-14T13:54:23Z

That's probably not me:

12:02:32 [K64F_armcc_minimal] Record #0: ERROR
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] u'macros' is not of type 'object'
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] Failed validating 'type' in schema:
12:02:32 [K64F_armcc_minimal]     {'properties': {u'module': {'type': u'string'},
12:02:32 [K64F_armcc_minimal]                     u'size': {'properties': {u'.bss': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                              u'.data': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                              u'.text': {'type': 'number'}},
12:02:32 [K64F_armcc_minimal]                               'type': 'object'},
12:02:32 [K64F_armcc_minimal]                     u'summary': {'properties': {'heap': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                                 'stack': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                                 'static_ram': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                                 'total_flash': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                                 'total_ram': {'type': 'number'}},
12:02:32 [K64F_armcc_minimal]                                  'type': 'object'}},
12:02:32 [K64F_armcc_minimal]      'type': 'object'}
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] On instance:
12:02:32 [K64F_armcc_minimal]     u'macros'
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] Record #1: ERROR
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] u'config' is not of type 'object'

bulislaw · 2018-03-16T09:57:06Z

@0xc0170 can we restart jenkins? ^^ looks rather random

jeromecoutant · 2018-03-19T15:27:24Z

TESTS/mbed_hal/lp_us_tickers/main.cpp

@@ -444,7 +444,7 @@ Case cases[] = {
    Case("hf ticker overflow test", hf_ticker_setup, ticker_overflow_test),
    Case("hf ticker increment test", hf_ticker_setup, ticker_increment_test),


Hi

Maybe not the good PR... but maybe we should rename hf ticker into us ticker here ?

I'll do it in a separate PR. I need this one ASAP to get docs generated .

bulislaw · 2018-03-19T21:11:25Z

@cmonr can we try to get that through CI and merged ASAP please.

cmonr · 2018-03-19T21:17:18Z

@bulislaw Looks like this was restarted earlier today (~5h ago), and still failed.

The repo that this looks like is failing against is https://github.com/ARMmbed/mbed-os-cliapp.

There were three failure causes, but this is the only error log that I could find was exported.

NRF52840_DK_armcc_minimal.log

cmonr · 2018-03-19T21:18:57Z

I suppose we could make an exception for PRs that aren't going into master to ignore this part of the pr-head build.

@adbridge @0xc0170 @sg- @OPpuolitaival Thoughts?

bulislaw · 2018-03-20T09:41:40Z

Ah, no that's my fault it's just hidden for some reason under

12:02:32 [K64F_armcc_minimal] Record #0: ERROR
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] u'macros' is not of type 'object'
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] Failed validating 'type' in schema:
12:02:32 [K64F_armcc_minimal]     {'properties': {u'module': {'type': u'string'},
12:02:32 [K64F_armcc_minimal]                     u'size': {'properties': {u'.bss': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                              u'.data': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                              u'.text': {'type': 'number'}},
12:02:32 [K64F_armcc_minimal]                               'type': 'object'},
12:02:32 [K64F_armcc_minimal]                     u'summary': {'properties': {'heap': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                                 'stack': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                                 'static_ram': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                                 'total_flash': {'type': 'number'},
12:02:32 [K64F_armcc_minimal]                                                 'total_ram': {'type': 'number'}},
12:02:32 [K64F_armcc_minimal]                                  'type': 'object'}},
12:02:32 [K64F_armcc_minimal]      'type': 'object'}
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] On instance:
12:02:32 [K64F_armcc_minimal]     u'macros'
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] Record #1: ERROR
12:02:32 [K64F_armcc_minimal] 
12:02:32 [K64F_armcc_minimal] u'config' is not of type 'object'

0xc0170 · 2018-03-20T09:48:53Z

I suppose we could make an exception for PRs that aren't going into master to ignore this part of the pr-head build.

Should not be any exception, make it green.
I looked at the last pr head failure, it is 2 compile errors that are related, undefined lp ticker data.

Ah, no that's my fault it's just hidden for some reason under

👍

bulislaw · 2018-03-20T09:53:45Z

Should not be any exception, make it green.

Actually it not related to my changes, it's broken on the branch and for some reason not caught by the testing before. Will fix it anyway.

OPpuolitaival · 2018-03-20T09:57:07Z

Yes we can make exceptions if not merged to the master but that is worst change

The current implementation of tickless requires LPTICKER to be present.

bulislaw · 2018-03-20T11:56:09Z

@OPpuolitaival I've disabled the Nordic boards because they don't support the low power timer and that also means no flash or trng which was causing issues for the cli tests. But the CI still fails, I can't really track what's going wrong, could you have a look and see what's wrong?

OPpuolitaival · 2018-03-20T12:50:19Z

@bulislaw I send some guidance to your mail. Can you check if that helps

bulislaw · 2018-03-20T15:36:30Z

@bulislaw I send some guidance to your mail. Can you check if that helps

@OPpuolitaival I did't get anything

OPpuolitaival · 2018-03-21T11:27:22Z

@bulislaw Now I sent that in right email address. That failure seems valid for me

OPpuolitaival · 2018-03-21T13:15:37Z

@bulislaw looks good now

0xc0170 · 2018-03-21T13:25:00Z

/morph build

mbed-ci · 2018-03-21T14:03:52Z

Build : FAILURE

Build number : 1514
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6351/

bulislaw · 2018-03-21T15:38:01Z

Doesn't look like my fault ;(

13:56:18 Extracting sources done..
13:56:19 [mbed] WARNING: Could not find mbed program in current path "/builds/ws/mbed-os-build-matrix/1514/ARM_CM3DS_MPS2_ARM/sources/mbed-os".
13:56:19 [mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
13:56:19 ---
13:56:41 [mbed] ERROR: "/usr/bin/python" returned error code 1.
13:56:41 [mbed] ERROR: Command "/usr/bin/python -u /builds/ws/mbed-os-build-matrix/1514/ARM_CM3DS_MPS2_ARM/sources/mbed-os/tools/test.py -t ARM -m ARM_CM3DS_MPS2 -c --source /builds/ws/mbed-os-build-matrix/1514/ARM_CM3DS_MPS2_ARM/sources/mbed-os --build /builds/ws/mbed-os-build-matrix/1514/ARM_CM3DS_MPS2_ARM/sources/mbed-os/BUILD/tests/ARM_CM3DS_MPS2/ARM --test-spec /builds/ws/mbed-os-build-matrix/1514/ARM_CM3DS_MPS2_ARM/sources/mbed-os/BUILD/tests/ARM_CM3DS_MPS2/ARM/test_spec.json -v -DMBED_HEAP_STATS_ENABLED=1 -DMBED_STACK_STATS_ENABLED=1 -DMBED_TRAP_ERRORS_ENABLED=1 --build-report-junit=/builds/ws/mbed-os-build-matrix/1514/ARM_CM3DS_MPS2_ARM/build_report_ARM_CM3DS_MPS2_ARM.xml" in "/builds/ws/mbed-os-build-matrix/1514/ARM_CM3DS_MPS2_ARM/sources/mbed-os"
13:56:41 ---
13:56:41 Total test binary build : 0
13:56:43 upload path : builds/6351/FAIL/ARM_CM3DS_MPS2/ARM
13:56:43 Completed 256.0 KiB/739.6 KiB (5.9 MiB/s) with 1 file(s) remaining
Completed 512.0 KiB/739.6 KiB (10.2 MiB/s) with 1 file(s) remaining
Completed 739.6 KiB/739.6 KiB (5.0 MiB/s) with 1 file(s) remaining 
upload: ./c20f916dee997e4ebf43e6eb067e2c2bcbc6241f_build_log_ARM_CM3DS_MPS2_ARM.txt to s3://mbed-os/builds/6351/FAIL/ARM_CM3DS_MPS2/ARM/c20f916dee997e4ebf43e6eb067e2c2bcbc6241f_build_log_ARM_CM3DS_MPS2_ARM.txt
13:56:43 
13:56:43 The user-provided path /builds/ws/mbed-os-build-matrix/1514/ARM_CM3DS_MPS2_ARM/c20f916dee997e4ebf43e6eb067e2c2bcbc6241f_example_build_log_ARM_CM3DS_MPS2_ARM.txt does not exist.

cmonr · 2018-03-21T16:22:17Z

Funky. Let's see if it does that again.

/morph build

mbed-ci · 2018-03-21T16:52:24Z

Build : FAILURE

Build number : 1520
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6351/

cmonr · 2018-03-21T19:16:14Z

@bulislaw Take another look at the logs. Looks like the PR is causing valid build issues.

One snippet from one of the failed builds:

[DEBUG] Compile: arm-none-eabi-gcc -std=gnu99 -c -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -fmessage-length=0 -fno-exceptions -fno-builtin -ffunction-sections -fdata-sections -funsigned-char -MMD -fno-delete-null-pointer-checks -fomit-frame-pointer -Os -g1 -mcpu=cortex-m3 -mthumb -DMBED_STACK_STATS_ENABLED=1 -D__MBED__=1 -DTARGET_LIKE_MBED -DDEVICE_PORTINOUT=1 -D__MBED_CMSIS_RTOS_CM -DMBED_TRAP_ERRORS_ENABLED=1 -DDEVICE_RTC=1 -DTARGET_ARM_CM3DS_MPS2 -D__CMSIS_RTOS -DTOOLCHAIN_GCC -DTARGET_ARM_IOTSS_Target -DTARGET_LIKE_CORTEX_M3 -DTARGET_CORTEX_M -DARM_MATH_CM3 -DTARGET_UVISOR_UNSUPPORTED -DTARGET_M3 -DMBED_HEAP_STATS_ENABLED=1 -DDEVICE_INTERRUPTIN=1 -DTARGET_CORTEX -DDEVICE_I2C=1 -DDEVICE_PORTOUT=1 -D__CORTEX_M3 -DMBED_BUILD_TIMESTAMP=1521650601.21 -DDEVICE_PORTIN=1 -DTARGET_RELEASE -DTARGET_CM3DS_MPS2 -DTOOLCHAIN_GCC_ARM -DTARGET_ARM_SSG -DCMSDK_CM3DS -DDEVICE_SPI=1 -DDEVICE_ETHERNET=1 -DDEVICE_ANALOGIN=1 -DDEVICE_SERIAL=1 -DTOOLCHAIN_object @/builds/ws/mbed-os-build-matrix/1520/ARM_CM3DS_MPS2_GCC_ARM/sources/mbed-os/BUILD/tests/ARM_CM3DS_MPS2/GCC_ARM/.includes_e34ee4eaba9e0a495e67a67bd58a5b64.txt -include /builds/ws/mbed-os-build-matrix/1520/ARM_CM3DS_MPS2_GCC_ARM/sources/mbed-os/BUILD/tests/ARM_CM3DS_MPS2/GCC_ARM/mbed_config.h -MD -MF BUILD/tests/ARM_CM3DS_MPS2/GCC_ARM/targets/TARGET_ARM_SSG/TARGET_CM3DS_MPS2/lp_ticker.d -o BUILD/tests/ARM_CM3DS_MPS2/GCC_ARM/targets/TARGET_ARM_SSG/TARGET_CM3DS_MPS2/lp_ticker.o /builds/ws/mbed-os-build-matrix/1520/ARM_CM3DS_MPS2_GCC_ARM/sources/mbed-os/targets/TARGET_ARM_SSG/TARGET_CM3DS_MPS2/lp_ticker.c
        [Error] lp_ticker.c@58,27: 'lp_ticker_irq_handler' undeclared here (not in a function)
        [Error] lp_ticker.c@90,30: unknown type name 'timestamp_t'
        [DEBUG] Return: 1
        [DEBUG] Output: /builds/ws/mbed-os-build-matrix/1520/ARM_CM3DS_MPS2_GCC_ARM/sources/mbed-os/targets/TARGET_ARM_SSG/TARGET_CM3DS_MPS2/lp_ticker.c:58:27: error: 'lp_ticker_irq_handler' undeclared here (not in a function)
        [DEBUG] Output:      .interval_callback = &lp_ticker_irq_handler,
        [DEBUG] Output:                            ^~~~~~~~~~~~~~~~~~~~~
        [DEBUG] Output: /builds/ws/mbed-os-build-matrix/1520/ARM_CM3DS_MPS2_GCC_ARM/sources/mbed-os/targets/TARGET_ARM_SSG/TARGET_CM3DS_MPS2/lp_ticker.c:90:30: error: unknown type name 'timestamp_t'
        [DEBUG] Output:  void lp_ticker_set_interrupt(timestamp_t timestamp)
        [DEBUG] Output:                               ^~~~~~~~~~~

cmonr · 2018-03-22T18:29:19Z

/morph build

mbed-ci · 2018-03-22T18:56:56Z

Build : SUCCESS

Build number : 1531
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6351/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-22T22:02:17Z

Exporter Build : SUCCESS

Build number : 1171
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6351/

mbed-ci · 2018-03-23T04:07:46Z

Test : FAILURE

Build number : 1311
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6351/1311

bulislaw · 2018-03-23T09:02:20Z

We have plenty of places where HAL is being used without checking for DEVICE_HAS, that will need to be fixed sooner or later. Removing NRF51_DK as some tests are passing without USTICKER.

0xc0170 · 2018-03-23T09:19:31Z

/morph build

mbed-ci · 2018-03-23T10:00:05Z

Build : SUCCESS

Build number : 1536
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6351/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-23T12:08:42Z

Test : SUCCESS

Build number : 1317
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6351/1317

mbed-ci · 2018-03-23T12:11:32Z

Exporter Build : SUCCESS

Build number : 1177
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6351/

bulislaw · 2018-03-23T12:40:12Z

@0xc0170 can we merge that please

Rename DEVICE_LOWPOWERTIMER to DEVICE_LPTICKER

a8b7d5c

That's to match DEVICE_USTICKER.

bulislaw requested review from c1728p9 and 0xc0170 March 13, 2018 17:41

bulislaw mentioned this pull request Mar 13, 2018

Rename LOWPOWERTICKER to LPTICKER ARMmbed/mbed-os-5-docs#452

Merged

cmonr added the needs: review label Mar 13, 2018

0xc0170 approved these changes Mar 14, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Mar 14, 2018

Disable Maxim boards as LP_TICKER is used in RTC and they don't respe…

fd8d139

…ct device_has

bulislaw force-pushed the feature-hal-spec-ticker branch from a0270ac to fd8d139 Compare March 14, 2018 11:44

jeromecoutant reviewed Mar 19, 2018

View reviewed changes

bulislaw added 3 commits March 20, 2018 10:15

Make sure LPTICKER symbols are not used for builds without it for Nordic

0db0c76

Don't use tickless if LPTICKER is not present

5f7d9a1

The current implementation of tickless requires LPTICKER to be present.

Disable RF52_DK as they require LPTICKER for flash and trng

c20f916

0xc0170 added needs: CI and removed needs: work labels Mar 21, 2018

0xc0170 added needs: work and removed needs: CI labels Mar 21, 2018

amq mentioned this pull request Mar 22, 2018

Add an option to use LowPowerTimer for poll #6418

Merged

5 tasks

Disable platfroms that fail without LPTICKER

800b806

Remove nrf51_dk from supported platform

0381a49

0xc0170 approved these changes Mar 23, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: work labels Mar 23, 2018

0xc0170 merged commit 77c36c0 into ARMmbed:feature-hal-spec-ticker Mar 23, 2018

0xc0170 removed the ready for merge label Mar 23, 2018

		@@ -444,7 +444,7 @@ Case cases[] = {
		Case("hf ticker overflow test", hf_ticker_setup, ticker_overflow_test),
		Case("hf ticker increment test", hf_ticker_setup, ticker_increment_test),

Rename DEVICE_LOWPOWERTIMER to DEVICE_LPTICKER #6351

Rename DEVICE_LOWPOWERTIMER to DEVICE_LPTICKER #6351

Uh oh!

Conversation

bulislaw commented Mar 13, 2018

Description

Pull request type

Uh oh!

0xc0170 commented Mar 14, 2018

Uh oh!

bulislaw commented Mar 14, 2018

Uh oh!

bulislaw commented Mar 14, 2018

Uh oh!

bulislaw commented Mar 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bulislaw commented Mar 19, 2018

Uh oh!

cmonr commented Mar 19, 2018

Uh oh!

cmonr commented Mar 19, 2018

Uh oh!

bulislaw commented Mar 20, 2018

Uh oh!

0xc0170 commented Mar 20, 2018

Uh oh!

bulislaw commented Mar 20, 2018

Uh oh!

OPpuolitaival commented Mar 20, 2018

Uh oh!

bulislaw commented Mar 20, 2018

Uh oh!

OPpuolitaival commented Mar 20, 2018

Uh oh!

bulislaw commented Mar 20, 2018

Uh oh!

OPpuolitaival commented Mar 21, 2018

Uh oh!

OPpuolitaival commented Mar 21, 2018

Uh oh!

0xc0170 commented Mar 21, 2018

Uh oh!

mbed-ci commented Mar 21, 2018

Uh oh!

bulislaw commented Mar 21, 2018

Uh oh!

cmonr commented Mar 21, 2018

Uh oh!

mbed-ci commented Mar 21, 2018

Uh oh!

cmonr commented Mar 21, 2018

Uh oh!

cmonr commented Mar 22, 2018

Uh oh!

mbed-ci commented Mar 22, 2018

Triggering tests

Uh oh!

mbed-ci commented Mar 22, 2018

Uh oh!

mbed-ci commented Mar 23, 2018

Uh oh!

bulislaw commented Mar 23, 2018

Uh oh!

0xc0170 commented Mar 23, 2018

Uh oh!

mbed-ci commented Mar 23, 2018

Triggering tests

Uh oh!

mbed-ci commented Mar 23, 2018

Uh oh!

mbed-ci commented Mar 23, 2018

Uh oh!

bulislaw commented Mar 23, 2018

Uh oh!

Uh oh!