-
Notifications
You must be signed in to change notification settings - Fork 3k
USB generic tests #6406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USB generic tests #6406
Conversation
TESTS/host_tests/pyusb_basic.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the ??? correspond to some sort of status?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for my private use :)
Will be removed soon
TESTS/host_tests/pyusb_basic.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there suppose to be a request that == 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for my private use :)
Will be removed soon
TESTS/host_tests/pyusb_basic.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this return in the middle of the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is used only for documentation purpose and will be removed soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor tweaks but after those updates are made it looks good.
TESTS/host_tests/pyusb_basic.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new reset tests I had to add a retry to get this to work correctly:
def find_device(self, serial_number):
for _ in range(20):
dev = usb.core.find(custom_match=TestMatch(serial_number))
if dev is not None:
break
time.sleep(0.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
TESTS/usb_device/basic/main.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If disconnect() + complete() occur too fast the reset event will be dropped. At a minimum there should be a 200us delay between disconnect and connect. To be on the safe side I would recommend a 1ms delay, so the host controller has an entire USB frame to detect the disconnect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
With #6403 and the above changes you should be able to get both the LPC1768 and K64F to pass testing. |
1869e11
to
d31bad6
Compare
/morph build |
Build : SUCCESSBuild number : 1519 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 1159 |
No obvious errors. Relaunching. |
Test : SUCCESSBuild number : 1297 |
d31bad6
to
59c799d
Compare
Exporter Build : SUCCESSBuild number : 1165 |
59c799d
to
4880d08
Compare
@maciejbocianski Should this still be marked as do not merge, as per the description? |
Could be merged. |
Description
USB generic test suite
In development
Pull request type