Add support for target MTB_ADV_WISE_1530. #6423

KariHaapalehto · 2018-03-22T10:39:33Z

Description

Add support for MTB_ADV_WISE_1530 and MTB_USI_WM_BN_BM_22 targets

Pull request type

0xc0170 · 2018-03-22T14:13:30Z

Can you please share tests (all compilers) ?

0xc0170

Just one nit

0xc0170 · 2018-03-23T18:02:04Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TARGET_MTB_ADV_WISE_1530/PinNames.h

+    GPIO2       = PB_1,
+    GPIO7       = PB_14,
+
+	I2S_CK		= PB_12,


misligned lines until 190?

ashok-rao

Suggest to remove USI MTB define from this PR as there are 2 separate targets and the USI needs separate pin defines.
Could you please address other comments. Thanks.

ashok-rao · 2018-03-26T09:01:01Z

targets/targets.json

+        "device_name": "STM32F412RG"
+    },
+    "MTB_USI_WM_BN_BM_22": {
+        "inherits": ["MTB_ADV_WISE_1530"],


Derivative target must not inherit from another target. It should inherit from parent MCU..

Will remove usi from here. There will be a lot of duplicate definitions, since the wise-1530 and USI targets are basicly the same targets. According the hw specification the wise-1530 includes usi chip. Only the tx&rx pins are diffrent with these 2 targets

ashok-rao · 2018-03-26T09:02:01Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TARGET_MTB_ADV_WISE_1530/PinNames.h

+    D13         = PA_5,
+    D14         = PB_9,
+    D15         = PB_8,
+


Please remove all Arduino pin defines. There are no Arduino connectors on the module.

ashok-rao · 2018-03-26T09:02:44Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TARGET_MTB_ADV_WISE_1530/PinNames.h

+    LED_RED     = GPIO0,
+    LED1 = LED_RED,
+    LED2 = LED_RED,
+    USER_BUTTON = GPIO2,


Please use standard button names.

ashok-rao · 2018-03-26T09:03:29Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TARGET_MTB_ADV_WISE_1530/PinNames.h

+    LED2 = LED_RED,
+    USER_BUTTON = GPIO2,
+    // Not connected
+    NC = (int)0xFFFFFFFF


All pins from the module must be defined. Even the non-connected ones. You may want to move the NC to the top for this.

ashok-rao · 2018-03-26T18:01:59Z

targets/TARGET_STM/mbed_rtx.h

@@ -100,7 +100,8 @@
       defined(TARGET_STM32F439ZI))
 #define INITIAL_SP              (0x20030000UL)

-#elif defined(TARGET_STM32F412ZG)
+#elif (defined(TARGET_STM32F412ZG) ||\
+       defined(TARGET_STM32F412RG))


I don't think this is required here as F412ZG and RG are differing only in package type..no difference in memory maps between the two variations.
I think the F412RG can be removed from here.. @cmonr @0xc0170 .. is this F412RG required here??

@ARMmbed/team-st-mcd Thoughts on the above question?

Hi, The SRAM memory is the same between F412ZG and F412RG. This is the reason why the stack pointer must be initialized at the same address for both Targets.
Please leave this line.

Kind regards

cmonr · 2018-03-26T20:04:02Z

Can you please share tests (all compilers) ?

Any update?

KariHaapalehto · 2018-03-27T12:34:09Z

Sw has been build with Jenkins job:
https://jenkins-internal.mbed.com/job/ipcore-cliapp-wiced-test-build/182/

Test's are running at the moment. Will link the results, once the test are done.

SeppoTakalo · 2018-03-28T08:48:31Z

@0xc0170 What test results are required?
How do we run those?

0xc0170 · 2018-03-28T09:38:32Z

@0xc0170 What test results are required?
How do we run those?

run mbed test for the specific target ( should run all tests for all toolchains) - should be all green. For example, can be seen here #5902 (the first comment, last section contains test results)

KariHaapalehto · 2018-03-29T09:31:50Z

test case results: 4 FAIL / 14 SKIPPED / 461 OK / 2 ERROR

Test results log-file also attached

ashok-rao · 2018-03-29T09:47:39Z

@0xc0170 @cmonr .. I'm also seeing these exact failures on another target I'm working on currently. The one I'm working on is also based on the same MCU as this MTB.. might be something related to the MCU timer/ticker implementation?

Alonof · 2018-04-09T12:50:57Z

targets/targets.json

+        "inherits": ["FAMILY_STM32"],
+        "core": "Cortex-M4F",
+        "extra_labels_add": ["STM32F4", "STM32F412xG", "STM32F412RG", "CORDIO"],
+        "device_has_add": ["CAN", "LOWPOWERTIMER", "SERIAL_ASYNCH", "SERIAL_FC", "TRNG", "FLASH"],


line 1141 and 1153 are overwritten each other both with label device_has_add

0xc0170 · 2018-04-09T13:52:08Z

@0xc0170 @cmonr .. I'm also seeing these exact failures on another target I'm working on currently. The one I'm working on is also based on the same MCU as this MTB.. might be something related to the MCU timer/ticker implementation?

@ashok-rao Has this been reported?

0xc0170 · 2018-04-09T15:27:53Z

Please rebase to resolve the conflict.

If we can report those issues that HAL implementation for a parent has?

ashok-rao · 2018-04-10T17:10:16Z

@0xc0170 , the failing tests are now reported as issue #6591 ..let's discuss there..thanks!

KariHaapalehto closed this Mar 22, 2018

KariHaapalehto deleted the mtb_adv_wise_1530 branch March 22, 2018 10:59

KariHaapalehto restored the mtb_adv_wise_1530 branch March 22, 2018 12:18

KariHaapalehto reopened this Mar 22, 2018

0xc0170 added the needs: review label Mar 22, 2018

0xc0170 previously approved these changes Mar 23, 2018

View reviewed changes

0xc0170 added the scope: new-target label Mar 23, 2018

KariHaapalehto dismissed 0xc0170’s stale review via fcc6359 March 26, 2018 07:28

ashok-rao suggested changes Mar 26, 2018

View reviewed changes

ashok-rao reviewed Mar 26, 2018

View reviewed changes

theotherjimmy added needs: work and removed needs: review labels Mar 29, 2018

ashok-rao mentioned this pull request Mar 29, 2018

Add new target USI WM-BN-BM-22 #6511

Merged

Alonof reviewed Apr 9, 2018

View reviewed changes

Add support for target MTB_ADV_WISE_1530.

bf82d20

ashok-rao mentioned this pull request Apr 10, 2018

lp_ticker and RTC tests failing for platforms based on STM32F412xx #6591

Closed

KariHaapalehto closed this Apr 11, 2018

sg- removed the needs: work label Apr 11, 2018

cmonr removed the scope: new-target label Apr 11, 2018

Add support for target MTB_ADV_WISE_1530. #6423

Add support for target MTB_ADV_WISE_1530. #6423

Uh oh!

Conversation

KariHaapalehto commented Mar 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

0xc0170 commented Mar 22, 2018

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented Mar 26, 2018

Uh oh!

KariHaapalehto commented Mar 27, 2018

Uh oh!

SeppoTakalo commented Mar 28, 2018

Uh oh!

0xc0170 commented Mar 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KariHaapalehto commented Mar 29, 2018

Uh oh!

ashok-rao commented Mar 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Apr 9, 2018

Uh oh!

0xc0170 commented Apr 9, 2018

Uh oh!

ashok-rao commented Apr 10, 2018

Uh oh!

Uh oh!

KariHaapalehto commented Mar 22, 2018 •

edited

Loading

0xc0170 commented Mar 28, 2018 •

edited

Loading