-
Notifications
You must be signed in to change notification settings - Fork 3k
Move mbed tls lib to separate folder #6636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mbed tls lib to separate folder #6636
Conversation
* "MBEDOS_MBEDTLS", "MBED_CLIENT_MBED_TLS" added as an example case to the STM32 family
I do not think this is correct. It was deliberately put into that folder to be available as the rest of the modules in mbed OS. good example is one opened Pr related #6577 I do not fully understand the compilation issues. But would like to hear more about cleaning up the codebase. |
@0xc0170 thank you for the feedback. I will try to improve the solution we are using currently. |
So in general the approach in mbed is to try to have features available in non "TARGET_" or "FEATURES_" folders if they might apply for multiple targets? Thank you. |
Can you give an example of this. Removing mbed-tls from the default compilation doesn't seem the right way to fix this. In general, the mbed-os is building all software capabilities for a single target by default and we're not looking to conditionally compile OS capabilities at the moment. |
ARM Internal Ref: IOTSSL-2241 |
We are closing this. Feel free to comment , we would like to understand what issues you were having. we can create a separate issue. |
Description
Move mbedtls feature into separate TARGET_MBEDOS_MBEDTLS in order to exclude it from compilation and clean up the codebase. Also solves some compilation issues for combinations of using / not using proper RNG devices.
As a consequence each device that would use MBEDTLS would need to explicitly enable it in targets.json or in mbed_app.json or in some other way.
This PR is related to ARMmbed/mbed-client#526 .
Pull request type
[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
FYI: @MarceloSalazar @karsev
Internal reference tridonic: @markus-becker-tridonic-com