Skip to content

Use SingletonPtr in Nanostack HAL #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2018
Merged

Use SingletonPtr in Nanostack HAL #6663

merged 1 commit into from
Apr 19, 2018

Conversation

kjbracey
Copy link
Contributor

Description

Avoid static data/code overhead when Nanostack HAL isn't in use.
Preparation for removal of FEATURE_COMMON_PAL.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@kjbracey
Use SingletonPtr in Nanostack HAL
123c182 
Avoid static data/code overhead when Nanostack HAL isn't in use.
Preparation for removal of FEATURE_COMMON_PAL.
@kjbracey
Copy link
Contributor Author

@SeppoTakalo - maybe cherry-pick this into your thing

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2018

/morph build

@0xc0170 0xc0170 requested a review from SeppoTakalo April 18, 2018 07:57
@SeppoTakalo
Copy link
Contributor

Cherry-picked this here: #6577

Tested with Mesh application against master(without this change), this PR and #6577
All seem to work.

SeppoTakalo
SeppoTakalo approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@mbed-ci
Copy link

mbed-ci commented Apr 18, 2018

Build : SUCCESS

Build number : 1781
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6663/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 18, 2018

Exporter Build : FAILURE

Build number : 1424
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6663/

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2018

cc @studavekar

/morph export-build

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2018

/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Apr 18, 2018

Test : SUCCESS

Build number : 1591
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6663/1591

@mbed-ci
Copy link

mbed-ci commented Apr 18, 2018

Exporter Build : FAILURE

Build number : 1433
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6663/

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 19, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Apr 19, 2018

Exporter Build : SUCCESS

Build number : 1441
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6663/

@0xc0170 0xc0170 merged commit cbb1033 into ARMmbed:master Apr 19, 2018
@0xc0170 0xc0170 mentioned this pull request Apr 19, 2018
Merged
@kjbracey kjbracey deleted the nshal-static-removal branch April 19, 2018 12:59
@adbridge
Copy link
Contributor

This has been added on top of #6627 which is targeted for 5.9

@kjbracey
Copy link
Contributor Author

Was marked as refactor, should not have been labelled for 5.8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjbracey @0xc0170 @SeppoTakalo @mbed-ci @adbridge