Skip to content

Test build: Reduce include command length #6968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

Resolves #6577

Tests are built in two passes:

  • Mbed OS as a lib (just .o files)
  • Each test is built and linked with the Mbed OS .o

The second pass involves scanning the build directory creating in the first
pass. This is where the bug lies: the second pass takes an absolute path to
the artifacts create by the first. This adds the directory containing mbed-os
to the each include path, and these extra characters exceed the maximum
command line length on windows.

This patch uses a relate path, eliminating the problem

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 22, 2018

Build : SUCCESS

Build number : 2096
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6968/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 22, 2018

@mbed-ci
Copy link

mbed-ci commented May 22, 2018

@cmonr
Copy link
Contributor

cmonr commented May 22, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants