adding TARGET MTS_DRAGONFLY_L471QG #7177
Conversation
targets/TARGET_STM/TARGET_STM32L4/TARGET_MTS_DRAGONFLY_L471QG/PinNames.h
Outdated
Show resolved
Hide resolved
|
Test results for all 3 toolchains - can you share them |
| I2C1_SDA = D14, | ||
| I2C3_SCL = D7, | ||
| I2C3_SDA = A5, | ||
|
|
There was a problem hiding this comment.
@cedrickkukela-cd : Can you please define defaults for each peripheral? I see there are multiple UART's, SPI's etc,
There was a problem hiding this comment.
Im not quite sure i understand the request here. Could you elaborate.
There was a problem hiding this comment.
You can create aliases for I2C_SDA = I2C1_SDA (or I2C3_SDA based on whichever you wish to make as default) (& similarly for all other peripherals) so that application code can invoke the peripheral & create the object with just I2C_SDA and not have to choose I2C1_SDA / I2C3_SDA / any other..
targets/targets.json
Outdated
| "extra_labels_add": ["STM32L4", "STM32L471QG", "STM32L471xG", "STM32L471xx"], | ||
| "config": { | ||
| "clock_source": { | ||
| "help": "Mask value : USE_PLL_HSE_EXTC (need HW patch) | USE_PLL_HSE_XTAL (need HW patch) | USE_PLL_HSI | USE_PLL_MSI", |
There was a problem hiding this comment.
What are the HW patches? documented somewhere?
There was a problem hiding this comment.
that is an error. I will go ahead and remove that.
|
adding mac |
|
GCC test results |
|
@cedrickkukela-cd Thanks for the test results, but we'll need them all passing before we can progress this PR. |
|
adding testing results and test spec ARMresults2.txt |
|
for full mbed support both requests are needed |
|
@cedrickkukela-cd Making sure I understand, is the intention that this PR go in, have #7304 be rebased, and then it goes in, or is #7304 a superset of this PR, meaning that this PR should be closed? |
|
@cedrickkukela-cd - I recommend that you focus this pull request on adding base support for this platform into Mbed-OS (not including the cellular interface). You can update your commits on the branch referenced in this PR to turn off cellular. Then make sure that all tests are passing. The team can then get it merged in. The other PR can add the changes necessary to enable the cellular interface. I still recommend keeping these efforts separate in order to allow for the cellular guys to focus their review on the other pull request. Please let me know if this makes sense. |
|
@maclobdell 👍 Sounds good to me |
|
closing in favor of #7304 |
Description
Adding Target for Multitech Dragonfly L471QG.
Pull request type