Skip to content

LoRaWAN: Wrong return code for JoinRequest retry #7520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2018
Merged

LoRaWAN: Wrong return code for JoinRequest retry #7520

merged 1 commit into from
Jul 19, 2018

Conversation

hasnainvirk
Copy link
Contributor

@hasnainvirk hasnainvirk commented Jul 16, 2018 •
edited
Loading

Description

51f92b0 introduced handling for connection attempts while a connection was already underway or have been
completed. Unfortunately a similar check slipped through and the stack was not able to continue
sending join requests if an error happened.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

LoRaWAN: Wrong return code for JoinRequest retry
4a4f8de 
ARMmbed@51f92b0 introduced
handling for connection attempts while a connection was already underway or have been
completed. Unfortunately a similar check slipped through and the stack was not able to continue
sending join requests if an error happened.
@hasnainvirk
Copy link
Contributor Author

@0xc0170 @cmonr Please review. Kevin is on vacation so there wont be anybody reviewing from WAN team. It's a one liner, so please go ahead and review.

@hasnainvirk hasnainvirk mentioned this pull request Jul 16, 2018
Merged
cmonr
cmonr approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonr
Copy link
Contributor

cmonr commented Jul 16, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 16, 2018

Build : SUCCESS

Build number : 2613
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7520/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 16, 2018

Test : FAILURE

Build number : 2363
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7520/2363

@cmonr
Copy link
Contributor

cmonr commented Jul 16, 2018

Not sure what happened here. Rerunning.

/morph test

@mbed-ci
Copy link

mbed-ci commented Jul 16, 2018

Test : SUCCESS

Build number : 2366
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7520/2366

@cmonr
Copy link
Contributor

cmonr commented Jul 19, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

Exporter Build : SUCCESS

Build number : 2275
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7520/

@cmonr cmonr merged commit d91d3a6 into ARMmbed:master Jul 19, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7520 from hasnainvirk/cont_join_issue
568713c 
LoRaWAN: Wrong return code for JoinRequest retry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hasnainvirk @cmonr @mbed-ci @0xc0170