enable MOTE_L152 for OS5 #7534

bentcooke · 2018-07-17T19:59:12Z

Description

Enabling OS5 support for the MOTE_L152RC target. This supersedes the now closed #6250.

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change

Test logs from mbed-os v5.9.2:
MOTE_L152RC_GCC_20180716-163839.log
MOTE_L152RC_IAR_20180717-111451.log
MOTE_L152RC_ARM_20180717-111451.log

NVStore ~~test failures appear to be heap related (32K RAM) and similar to comments on #7127. Needs further investigation.~~ fixed! Depends on #7746
IAR Filesystem ~~test failures are also likely due to lack of heap and this target should have these tests disabled. Issue #6008.~~ fixed with rebase.
lpticker test ~~failures being reported in separate issue.~~ fixed with commit "Increase max func exec time to allow slower sys clock" in this PR

@dudmuck

Updated logs showing all previously failing tests now passing:
MOTE_L152RC_ARM_20180822-111451.log
MOTE_L152RC_GCC_20180822-163839.log
MOTE_L152RC_IAR_20180822-111451.log

Dependent PR: #7746

cmonr

Gonna ask that the tabs be replaced with spaces.

Otherwise, looks good and should be able to start CI.

cmonr · 2018-07-18T03:11:25Z

@ARMmbed/mbed-os-storage Thoughts on possible rememdies for the NVstore and IAR filesystem issues?

@bentcooke Mind mentioning the issue number here?

bentcooke · 2018-07-18T15:20:22Z

@cmonr tabs removed! What issue are you referring to?

cmonr · 2018-07-19T01:10:25Z

@bentcooke I was asking about the issues referenced in the PR description.

bentcooke · 2018-07-19T15:35:51Z

Here they are:
#7557
#7555

cmonr · 2018-07-20T13:31:39Z

@bentcooke Thanks.

For reference though, this will need to pass all tests before it can be brought in.

cmonr · 2018-07-30T16:11:02Z

@bentcooke In reference to #7557 (comment), would you mind making a comment here once that PR is ready so we can track the dependency?

bentcooke · 2018-07-31T18:14:32Z

@cmonr I already pulled the commits into this PR to update the lp ticker speed test to allow for slower sys clocks (Issue #7557) and to remove this target from the filesystem tests due to the heap limitations(Issue #6008).
Would you prefer separate PRs for these changes?

cmonr · 2018-07-31T18:38:18Z

@bentcooke This is fine, since they're seperate commits.

@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-hal Could y'all take a look at the small test changes?

bentcooke · 2018-08-08T08:13:40Z

@cmonr How can we get this moving again?

cmonr · 2018-08-08T12:44:16Z

@bentcooke Still waiting on @mbed-os-hal and @ARMmbed/mbed-os-storage to take a look at the test changes. I recall there being some lengthy discussion about the test timings, so I want to get their input on the chance.

In the meanwhile, I think we can start CI since enabling Mbed OS 5 might bring up some issues to correct in the meanwhile.

/morph build

dannybenor · 2018-08-08T12:52:00Z

@davidsaada is there a better way to run these tests?

davidsaada · 2018-08-08T13:27:23Z

features/TESTS/filesystem/buffered_block_device/main.cpp

@@ -23,6 +23,11 @@

 using namespace utest::v1;

+// TODO HACK, replace with available ram/heap property
+#if defined(TARGET_MTB_MTS_XDOT) || defined(TARGET_MOTE_L152RC)


Excluding specific boards is probably not the best way to handle these failures.

That is correct, TODO HACK shall be removed

I agree that this is not ideal, but I was following precedent set here:
dcd0e6b#diff-4e5d26193a7c8cf8e05e95d7775dcf84

davidsaada · 2018-08-08T13:32:36Z

@dannybenor et al. Excluding specific platforms from tests is probably not the best way to solve these problems. Now, I believe that the problem is similar to the one we see in #7712. To make a long story short, the problem is not with the test itself, but with the stack stats that generate a report, allocating more memory for this purpose. Problem is in the NVStore test itself. I have created #7746 to fix this issue. @bentcooke Please check whether this PR resolves your problem (without the need to exclude your platform specifically).

bentcooke · 2018-08-14T19:37:59Z

Followed up on #7746

cmonr · 2018-08-15T03:29:01Z

@davidsaada @bentcooke I'm not sure I follow the latest comments. Has work migrated to another PR? Is this one good to go?

davidsaada · 2018-08-15T10:33:21Z

I'm not sure I follow the latest comments. Has work migrated to another PR? Is this one good to go?

Not exactly. Wasn't fond of some the changes here, specifically all the ones excluding this platform from failing tests. The failing BD tests were fixed in other PRs. The NVStore test, however, keeps failing on hard fault, something which needs to be debugged.

davidsaada · 2018-08-19T11:56:22Z

@bentcooke
After rebasing this PR on top of master and #7746 all the problematic tests pass, including the NVStore one (tested with your MOTE_L152 board). This can be found under davidsaada/mbed-os:david_nvstore_test_low_mem_mote_l152rc branch.
What I suggest is the following:

Revert all changes in test codes, ones that exclude this target specifically (4 files). This will leave you with just two files in this PR (common_tickers main and tagets.json).
Rebase (this will handle failures in block device tests).
Make this PR depend on #7746. This will handle the NVStore failure.

bentcooke · 2018-08-22T19:57:30Z

@davidsaada The fork has been rebased, commit omitting target removed and retested. It appears that all tests are now passing after the rebase and applying the fix from #7746. Thanks for the help with this one!

I have updated the top comment in this thread with the new logs and comments.

0xc0170 · 2018-08-23T12:34:39Z

@davidsaada Please review again

davidsaada

Looks great now. Thanks.

0xc0170 · 2018-08-24T13:02:06Z

/morph build

mbed-ci · 2018-08-24T15:47:31Z

Build : SUCCESS

Build number : 2895
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7534/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-08-24T18:01:20Z

Exporter Build : SUCCESS

Build number : 2520
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7534/

mbed-ci · 2018-08-25T05:10:35Z

Test : SUCCESS

Build number : 2646
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7534/2646

cmonr added the scope: new-target label Jul 18, 2018

cmonr suggested changes Jul 18, 2018

View reviewed changes

cmonr added the needs: work label Jul 18, 2018

bentcooke force-pushed the mote_L152_en_os5 branch from 96c309e to a31b31d Compare July 18, 2018 15:18

cmonr approved these changes Jul 19, 2018

View reviewed changes

cmonr added the needs: review label Jul 19, 2018

cmonr requested a review from a team July 19, 2018 15:23

cmonr removed the needs: work label Jul 19, 2018

0xc0170 added needs: work and removed needs: review labels Jul 25, 2018

cmonr added needs: review and removed needs: work labels Jul 30, 2018

cmonr added needs: work and removed needs: review labels Jul 30, 2018

cmonr added the needs: review label Jul 31, 2018

cmonr requested a review from a team July 31, 2018 18:38

cmonr removed the needs: work label Jul 31, 2018

davidsaada suggested changes Aug 8, 2018

View reviewed changes

cmonr added needs: work and removed needs: review labels Aug 8, 2018

davidsaada mentioned this pull request Aug 9, 2018

Handle NVStore tests in a low memory environment #7746

Merged

bentcooke force-pushed the mote_L152_en_os5 branch from 4ad2e19 to c075a5e Compare August 22, 2018 16:44

ben and others added 2 commits August 22, 2018 11:49

enable MOTE_L152 for OS5

32647e6

Increase max func exec time to allow slower sys clock

42a49a5

bentcooke force-pushed the mote_L152_en_os5 branch from c075a5e to 42a49a5 Compare August 22, 2018 16:49

bentcooke mentioned this pull request Aug 22, 2018

lp ticker speed test failure for MOTE_L152RC target #7557

Closed

0xc0170 approved these changes Aug 23, 2018

View reviewed changes

0xc0170 added needs: review and removed needs: work labels Aug 23, 2018

davidsaada approved these changes Aug 23, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Aug 23, 2018

cmonr added the release-version: 5.9.7 label Aug 24, 2018

NirSonnenschein added ready for merge and removed needs: CI labels Aug 26, 2018

0xc0170 merged commit ce28c91 into ARMmbed:master Aug 27, 2018

0xc0170 removed the ready for merge label Aug 27, 2018

enable MOTE_L152 for OS5 #7534

enable MOTE_L152 for OS5 #7534

Uh oh!

Conversation

bentcooke commented Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

cmonr left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Jul 18, 2018

Uh oh!

bentcooke commented Jul 18, 2018

Uh oh!

cmonr commented Jul 19, 2018

Uh oh!

bentcooke commented Jul 19, 2018

Uh oh!

cmonr commented Jul 20, 2018

Uh oh!

cmonr commented Jul 30, 2018

Uh oh!

bentcooke commented Jul 31, 2018

Uh oh!

cmonr commented Jul 31, 2018

Uh oh!

bentcooke commented Aug 8, 2018

Uh oh!

cmonr commented Aug 8, 2018

Uh oh!

dannybenor commented Aug 8, 2018

Uh oh!

davidsaada Aug 8, 2018

Choose a reason for hiding this comment

Uh oh!

0xc0170 Aug 8, 2018

Choose a reason for hiding this comment

Uh oh!

bentcooke Aug 14, 2018

Choose a reason for hiding this comment

Uh oh!

davidsaada commented Aug 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bentcooke commented Aug 14, 2018

Uh oh!

cmonr commented Aug 15, 2018

Uh oh!

davidsaada commented Aug 15, 2018

Uh oh!

davidsaada commented Aug 19, 2018

Uh oh!

bentcooke commented Aug 22, 2018

Uh oh!

0xc0170 commented Aug 23, 2018

Uh oh!

davidsaada left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Aug 24, 2018

Uh oh!

mbed-ci commented Aug 24, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Aug 24, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Aug 25, 2018

Test : SUCCESS

Uh oh!

Uh oh!

bentcooke commented Jul 17, 2018 •

edited

Loading

davidsaada commented Aug 8, 2018 •

edited

Loading