-
Notifications
You must be signed in to change notification settings - Fork 3k
skip the flashsim test if not enough memory cannot be allocated for it. #7696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@davidsaada please review |
cc @andrewc-arm |
@aashishc1988 2k of heap not available? At least that is what I am reading how much it allocates there. There are minimum req that this target should met. I believe 2k of heap should be available for IAR |
@ARMmbed/mbed-os-storage Could someone review? |
@c1728p9 Fyi |
@0xc0170 Can you point me to the place where I can find the minimum requirement for this target? |
I was more about the usability. I don't think we got it documented but generally if there is not even 2kB of heap, where is all that memory allocated? That is what I am after - if there is a target there, how much RAM it actually has available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
(Thought I already did the same for this one. 👍 )
@aashishc1988 Can you rebase and we shall start CI soon for this one |
ccc4626
to
887aafe
Compare
@0xc0170 Rebased. |
/morph build |
Build : SUCCESSBuild number : 3157 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2761 |
Test : SUCCESSBuild number : 2968 |
Along the lines of, #7465, we need to skip flashsim test if we cannot allocate enough memory for it. We have seen the test failing on wizwiki_7500 for IAR toolchain, http://mbed-ci-master-2.austin.arm.com:8081/job/text_matrix_raas_staging/91/target=WIZWIKI_W7500,toolchain=IAR/consoleFull.
Failure log snippet: