STM32 RTC : write RTC time while LPTICKER is enabled #8286
Conversation
targets/TARGET_STM/rtc_api.c
Outdated
There was a problem hiding this comment.
Was something calling this outside a critical section?
There was a problem hiding this comment.
I added protection, as rtc_write and rtc_read_lp functions can update the same variables
targets/TARGET_STM/rtc_api.c
Outdated
There was a problem hiding this comment.
Does this always fit into a uint32_t ? or would a uint64_t be required ?
Also is LP_last_RTC_time in real seconds ? or µs ?
targets/TARGET_STM/rtc_api.c
Outdated
There was a problem hiding this comment.
Not clear to me what the comment says and how it relates to the code below: where is Subsecond counter reset to PREDIV_S_VALUE ?
targets/TARGET_STM/rtc_api.c
Outdated
There was a problem hiding this comment.
Where is the sub-second part retrieved from and how is it computed ?
targets/TARGET_STM/rtc_api.c
Outdated
There was a problem hiding this comment.
what is "last counter update" ? do you mean RTC_write (like application set_time()) ?
Does this comment apply here or in RTC_write function ?
targets/TARGET_STM/rtc_api.c
Outdated
There was a problem hiding this comment.
is RTC_time_s still in seconds ? the operation seems to mix it with sub_seconds. If so, need to rename the variable.
targets/TARGET_STM/rtc_api.c
Outdated
There was a problem hiding this comment.
Would be great to explain in commit message how those 3 variables are used:
LP_continuous_time : is it the time in µsec since start-up ?
RTC_time_s: the current time that was just read from RTC register ?
LP_last_RTC_time: the last time read from RTC register, either in this function, or in RTC_write() ?)
I don't undertstand the "add 24h" case ...
This fix avoid a long waiting loop in rtc_write function, which was not acceptable in TICKLESS context. Implementation comments added. Global variable name has been updated for easier maintenance: - LPTICKER_counter is the U32 continuous tick counter - LPTICKER_RTC_time is the RTC time used to get the time difference between rtc_read_lp() calls
jeromecoutant
force-pushed
the
PR_RTCWRITE
branch
from
0362e53 to
83caa04
Compare
|
@LMESTM please check updates |
|
/morph build |
Build : SUCCESSBuild number : 3274 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2899 |
Test : SUCCESSBuild number : 3082 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 2909 |
7 participants
Description
During RTC register write, only the date and time counters are set,
the SubSecond part is reset.
In the previous implementation, there was a quite long loop (up to 1 second).
@LMESTM @c1728p9 @mattbrown015
Pull request type