Skip to content

[LPC4088] Bugfixes related to I2C and Port implementations #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2013
Merged

[LPC4088] Bugfixes related to I2C and Port implementations #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a574fd7
Bugfixes for I2C and port impl
arebert Oct 11, 2013
a0a6cbe
Merge branch 'master' into lpc4088
arebert Oct 11, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions libraries/mbed/targets/hal/TARGET_NXP/TARGET_LPC408X/i2c_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,15 @@ void i2c_init(i2c_t *obj, PinName sda, PinName scl) {

pinmap_pinout(sda, PinMap_I2C_SDA);
pinmap_pinout(scl, PinMap_I2C_SCL);

// OpenDrain must explicitly be enabled for p0.0 and p0.1
if (sda == P0_0) {
pin_mode(sda, OpenDrain);
}
if (scl == P0_1) {
pin_mode(scl, OpenDrain);
}

}

inline int i2c_start(i2c_t *obj) {
Expand Down
3 changes: 2 additions & 1 deletion libraries/mbed/targets/hal/TARGET_NXP/TARGET_LPC408X/port_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
#include "pinmap.h"
#include "gpio_api.h"


PinName port_pin(PortName port, int pin_n) {
return (PinName)(LPC_GPIO0_BASE + ((port << PORT_SHIFT) | pin_n));
return (PinName)(((port << PORT_SHIFT) | pin_n));
}

void port_init(port_t *obj, PortName port, int mask, PinDirection dir) {
Expand Down