-
Notifications
You must be signed in to change notification settings - Fork 3k
Clean up deprecated feature code #8685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up deprecated feature code #8685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just curious what lib1 and lib2 are
@@ -2,7 +2,7 @@ | |||
"name": "lib1", | |||
"target_overrides": { | |||
"*": { | |||
"target.features_add": ["IPV4"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libl?
Also, it has a bootloader?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib1 and lib2 are just arbitrary names for "libraries" in this test. The name of the libraries don't matter and don't affect the contents of the test. They just need to be distinct.
It also doesn't actually have a bootloader, I just needed a feature label that wasn't deprecated. Strangely/happily enough, we don't have that many more deprecated feature labels! I picked the BOOTLOADER
one since I figured that would be around the longest so I (hopefully) don't have to update these tests in the near future 😄
/morph build |
Build : SUCCESSBuild number : 3619 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 3227 |
Well, I suppose it has been a while since we've last seen this issue... Will restart when able. |
Test : SUCCESSBuild number : 3402 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 3239 |
Description
This is a follow up to #7799. Where that PR is expected to fail, this PR should pass CI. This is only cleaning up the use of deprecated features (and the generated macros) throughout the code base.
One thing to note, while rebasing this PR I noticed that #7592 removed a config test that used the UVISOR feature, but wasn't uVisor specific (it tested a real use case). I've readded this test case to gain the coverage and tweaked it to use other currently available FEATURES.
Pull request type